Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix troute build #833

Merged
merged 1 commit into from
Jun 12, 2024
Merged

ci: fix troute build #833

merged 1 commit into from
Jun 12, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jun 11, 2024

Fix t-route CI builds after changes introduced in NOAA-OWP/t-route#780. NOAA-OWP/t-route#780 at its core addressed the need for the python wheel package as a build time dependency. wheel was not installed in CI before attempting to build t-route. This addresses that. (NOAA-OWP/t-route#782 addressed this).

Edit: The failure was due to a change in setuptools editable installation mode. This change was introduced in setuptools 64 but was not enforced for packages that did not define a pyproject.toml metadata file. In the CI action, setuptools was being updated to the latest version and t-route packages were being installed with --editable mode enable. NOAA-OWP/t-route#780 added pyproject.toml files to t-route packages.

The solution ended up being trivial, just install the packages in normal non-editable mode.

@aaraney
Copy link
Member Author

aaraney commented Jun 11, 2024

Testing this with the pinned pip dep now just to make sure this solves the issue. Once the tests pass, I will remove the pinning of the pip version in CI and include that as part of this PR.

@aaraney aaraney force-pushed the fix-ci branch 6 times, most recently from b252b56 to 904c4fb Compare June 11, 2024 19:20
@hellkite500 hellkite500 marked this pull request as draft June 11, 2024 22:24
@aaraney
Copy link
Member Author

aaraney commented Jun 12, 2024

Okay, so that is getting somewhere. It looks like setuptools or a transient dependency of setuptools is causing the issue (see https://github.com/NOAA-OWP/ngen/actions/runs/9486412729/workflow#L104). Things are passing when setuptools is not upgraded. Going to investigate that now.

@aaraney aaraney changed the title ci: install missing wheel pkg for troute build ci: fix troute build Jun 12, 2024
@hellkite500 hellkite500 marked this pull request as ready for review June 12, 2024 21:12
@hellkite500 hellkite500 merged commit 74a3ef3 into NOAA-OWP:master Jun 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants