Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc cleanup: 'using namespace' and unnecessary 'friend' #844

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Jun 27, 2024

Just clearing out some poor form C++ that I noticed

Changes

  • Eliminate using namespace models::bmi in headers
  • Eliminate using namespace hy_features::hydrolocation; in header
  • Delete unnecessary friend class Bmi_Multi_Formulation
  • Shift a header include from header where it wasn't needed to source files that actually depended on it

Testing

Code still builds

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller PhilMiller requested a review from program-- June 27, 2024 17:47
@program-- program-- merged commit b5e5361 into NOAA-OWP:master Jun 27, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/misc-cleanup branch June 27, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants