Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate outputs of realization config in MPI computation #866

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

stcui007
Copy link
Contributor

@stcui007 stcui007 commented Aug 6, 2024

When running a MPI job, the content of realization configs (submodules) is printed out multiple times equal to the number of processors used. This PR modifies the behavior so that only one copy is printed out.

Additions

Removals

Changes

Codes as listed in the commit.

Testing

  1. Unit tests on Linux pass except test_routing_pybind
  2. MPI run test

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

@stcui007
Copy link
Contributor Author

stcui007 commented Aug 6, 2024 via email

@stcui007 stcui007 marked this pull request as ready for review August 7, 2024 13:09
@PhilMiller PhilMiller merged commit 088fc26 into NOAA-OWP:master Aug 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants