generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Coastal Runs #834
Draft
shorvath-noaa
wants to merge
14
commits into
NOAA-OWP:master
Choose a base branch
from
shorvath-noaa:coastal_runs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorvath-noaa
requested review from
kumdonoaa,
AminTorabi-NOAA and
JurgenZach-NOAA
August 27, 2024 17:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT READY TO MERGE
This contains a few updates to run on v2.2 of the hydrofabric. These edits have been focused on producing valid output for the inland/coastal coupling exercise. The main features are working with v2.2 of the hydrofabric, accessing gage crosswalk information for streamflow nudging, and accessing POI crosswalk information that is now included in the
stream_output
output files.TODO
We will need to ensure backwards compatibility with older versions of the hydrofabric. This might not be necessary eventually, but for the time being I believe users are still running t-route on older versions, so we want to maintain that.
Additions
poi_crosswalk
info from the hydrofabric to output files.Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other