Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #2 and breaks caused by '^M' characters #4

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

jtsiddons
Copy link

Python version of COARE 3.5 was broken. '^M' (equivalent to carriage return) characters had been introduced in all files. This is the main cause of issue #2 (the new lines introduced by '^M' resulted in empty lines being read and np.float('')).

Note that the original coare35vn.py file had been forced into a single line.

This also implements the fix to meteo.rhod following pull request #3 by @milancurcic

Other misc fixes:

  • Update np.float and np.int to 64-bit versions (originals are depreciated in recent numpy versions)
  • Use relative path os.path.dirname(__file__) to refer to the data file - users no longer need to edit the script (also in COARE 3.6)
  • Auto-formats using python black + moving imports to top of file
  • Syntax changes (print, raise) for python 3

@deszoeke
Copy link

deszoeke commented May 8, 2024

I have not tested, but approve of these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants