Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Generic Layers2Pressure Class #25

Merged
merged 5 commits into from
Sep 26, 2024
Merged

More Generic Layers2Pressure Class #25

merged 5 commits into from
Sep 26, 2024

Conversation

timothyas
Copy link
Member

@timothyas timothyas commented Sep 25, 2024

There were a couple of issues with the Layers2Pressure module/class:

  1. It only worked with the UFS vertical grid (127 vertical levels etc)
  2. It uses "level" as the label for the vertical coordinate, not "pfull", which is what FV3 calls it

This PR addresses both of those issues. Some outstanding issues though:

  • either remove or finish off the commented code at the bottom, which starts to implement the pfull/level renaming
  • update the jupyter notebook documentation
  • bump version

@timothyas timothyas merged commit 83f03a6 into main Sep 26, 2024
3 checks passed
@timothyas timothyas deleted the feature/generic-l2p branch September 26, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant