Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss choice: instantiate with hydra #255

Closed
remtav opened this issue Feb 1, 2022 · 1 comment
Closed

Loss choice: instantiate with hydra #255

remtav opened this issue Feb 1, 2022 · 1 comment
Assignees

Comments

@remtav
Copy link
Collaborator

remtav commented Feb 1, 2022

See similar issue #246

Currently, choosing a loss in model_choice.py calls an init_.py that makes use of a series of disorganized if-else statements.
Choosing a model can be much more straight forward by using config files for each relevant loss and pointing to the model class directly in this config file. See hydra's documentation on Class instantiation.

@CharlesAuthier CharlesAuthier self-assigned this Feb 3, 2022
@remtav
Copy link
Collaborator Author

remtav commented Feb 8, 2022

closed with #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants