Hydra: Create optimizer using instantiate() #293
Comments
|
Yesss |
remtav
added a commit
that referenced
this issue
Mar 29, 2022
…sses) from checkpoint (#298) * fixes #293 #246 add tests for optimizer instantiation in test_optimizers.py adapt our unet models (models/unet.py) to expect same parameter names as smp models * minor typo fixes * implement overriding model params from checkpoint with minimal error handling for checkpoints from different gdl versions fixes #183 * name model yamls as close as possible to upcoming naming convention * fix model name * implement overriding model params from checkpoint with minimal error handling for checkpoints from different gdl versions fixes #183 * small bugfix for pointing to parameters inside checkpoint * model_choice.py: add update checkpoint utility * fixes #293 #246 add tests for optimizer instantiation in test_optimizers.py adapt our unet models (models/unet.py) to expect same parameter names as smp models * minor typo fixes * name model yamls as close as possible to upcoming naming convention * small bugfix for pointing to parameters inside checkpoint * remove deeplabv3 dualhead warning and add link for deeplabv3_dualhead.py * fixes #293 #246 add tests for optimizer instantiation in test_optimizers.py adapt our unet models (models/unet.py) to expect same parameter names as smp models * name model yamls as close as possible to upcoming naming convention * minor typo fixes * update to PR 295 * GDL.py: restore to previous commit based on cauthier's comment
remtav
added a commit
to remtav/geo-deep-learning
that referenced
this issue
Jul 5, 2022
…sses) from checkpoint (NRCan#298) * fixes NRCan#293 NRCan#246 add tests for optimizer instantiation in test_optimizers.py adapt our unet models (models/unet.py) to expect same parameter names as smp models * minor typo fixes * implement overriding model params from checkpoint with minimal error handling for checkpoints from different gdl versions fixes NRCan#183 * name model yamls as close as possible to upcoming naming convention * fix model name * implement overriding model params from checkpoint with minimal error handling for checkpoints from different gdl versions fixes NRCan#183 * small bugfix for pointing to parameters inside checkpoint * model_choice.py: add update checkpoint utility * fixes NRCan#293 NRCan#246 add tests for optimizer instantiation in test_optimizers.py adapt our unet models (models/unet.py) to expect same parameter names as smp models * minor typo fixes * name model yamls as close as possible to upcoming naming convention * small bugfix for pointing to parameters inside checkpoint * remove deeplabv3 dualhead warning and add link for deeplabv3_dualhead.py * fixes NRCan#293 NRCan#246 add tests for optimizer instantiation in test_optimizers.py adapt our unet models (models/unet.py) to expect same parameter names as smp models * name model yamls as close as possible to upcoming naming convention * minor typo fixes * update to PR 295 * GDL.py: restore to previous commit based on cauthier's comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As was done with losses in #255 and as will be done with model architectures in #246, optimizers should be instantiated with hydra's instantiate() function and config parameters should be adapted accordingly.
The text was updated successfully, but these errors were encountered: