260 remove classif #263
260 remove classif #263
Conversation
resuscitate train_classification.py resuscitate inference_classification.py add classif template config replace load_obj() with hydra's get_method remove task config directory
| task_name: segmentation | ||
| path_task_function: ${mode}_segmentation.main |
There was a problem hiding this comment.
@CharlesAuthier let me know if there was a particular reason you wanted it like this.
| ./22978945_15.tif,,./massachusetts_buildings.gpkg,,trn | ||
| ./23429155_15.tif,,./massachusetts_buildings.gpkg,,tst |
There was a problem hiding this comment.
This change is temporary. Will refactor the in_case_of_path parameter. I'd rather use hydra.utils.get_original_cwd().
| @@ -427,7 +424,7 @@ def try2read_csv(path_file, in_case_of_path, msg): | |||
| Path(path_file).resolve(strict=True) | |||
| except FileNotFoundError: | |||
| if in_case_of_path: | |||
| path_file = os.path.join(in_case_of_path, os.path.basename(path_file)) | |||
| path_file = str(Path(in_case_of_path) / (path_file.split('./')[-1])) | |||
| try: | |||
There was a problem hiding this comment.
I'll get back to this in_case_of_path story in a future PR. Would like to suggest a different, lighter approach with hydra.utils.get_original_cwd()
| raise AttributeError(f"Object `{obj_name}` cannot be loaded from from `{obj_path}`.") | ||
| return getattr(module_obj, obj_name) | ||
|
|
||
|
|
There was a problem hiding this comment.
@CharlesAuthier same here. Let me know if you had anytning in my mind for further developments with this function. If the purpose was just to use in GDL.py to reach the right method, I think hydra.utils.get_method() does the job.
|
you have a conflict, after change for it I will approve |
| # Save tracking TODO put option not just mlflow | ||
| if 'tracker_uri' in locals() and 'run_name' in locals(): |
There was a problem hiding this comment.
No major change here, git's just having a hard time following the movement of big blocks of code.
| attribute_name=attribute_field, |
There was a problem hiding this comment.
Same here. Nothing major has happened. Just deindented after removing if/else for classif/segmentation task.
replace load_obj() with hydra's get_method remove task config directory * remove classification stuff
Also:
replace load_obj() with hydra's get_method
remove task config directory
closes #260