558 implement a base class for scripting models #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesAuthier
previously approved these changes
May 8, 2024
config/gdl_config_template.yaml
Outdated
| @@ -34,7 +34,7 @@ general: | |||
| raw_data_dir: data | |||
| raw_data_csv: tests/tiling/tiling_segmentation_binary_ci.csv | |||
| tiling_data_dir: ${general.raw_data_dir}/patches # where the patches will be saved | |||
| save_weights_dir: saved_model/${general.project_name} | |||
There was a problem hiding this comment.
why changing the template?
There was a problem hiding this comment.
I changed it because the default ParentPath is set to the current working directory which might not be desirable.
There was a problem hiding this comment.
Change reverted beause it fails tests!
valhassan
dismissed
CharlesAuthier’s stale review
The merge-base changed after approval.
added 2 commits
May 8, 2024 13:51
CharlesAuthier
previously approved these changes
May 9, 2024
remtav
reviewed
May 13, 2024
| @@ -0,0 +1,32 @@ | |||
| import torch | |||
|
|
|||
| class ScriptModel(torch.nn.Module): | |||
There was a problem hiding this comment.
Hey! Very curious to start using scripted models. Thanks for this addition. Could a test for the __init__ and forward() to validate these methods act as expected be relevant?
There was a problem hiding this comment.
yes, I added tests.
CharlesAuthier
approved these changes
May 14, 2024
LucaRom
reviewed
May 14, 2024
LucaRom
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting your PR and helping us with GDL.
Please read the template below, fill it out as appropriate, and make additional changes to your code as needed.
Please feel free to submit your PR even if it doesn't satisfy all of the requirements below.
If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively.
After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.
Description
Please include a summary of the change and which issue is resolved (if applicable).
Please also include relevant motivation and context.
List any dependencies that are required for this change.
If it fixes an open issue, please link to the issue here.
Fixes #558
Type of change
What types of changes does your code introduce? Put an
xin all the boxes that apply:How Has This Been Tested?
If the added changes are already cover by tests, skip that section.
Otherwise, please describe tests that you added to the pytest codebase (if applicable).
Screenshots (if applicable):
Checklist:
If you're unsure about any of these, don't hesitate to ask. We're here to help!
If your PR does not fulfill all of the requirements in the checklist above, that's OK! If you need help, @-mention a maintainer and/or add the Status: Help Needed label.