Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

570 bug remove solaris #571

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Conversation

valhassan
Copy link
Collaborator

Description

If it fixes an open issue.
Fixes #570

Type of change

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other

How Has This Been Tested?

If the added changes are already cover by tests, skip that section.
Otherwise, please describe tests that you added to the pytest codebase (if applicable).

Screenshots (if applicable):

Checklist:

If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • My PR has a descriptive title
  • My code follows PEP8 (most of it)
  • My code have the proper documentation in the code
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new errors
  • My code is covered by the existing tests (if applicable)
  • My code includes tests that show that my feature works
  • My PR passes Travis CI tests

If your PR does not fulfill all of the requirements in the checklist above, that's OK! If you need help, @-mention a maintainer and/or add the Status: Help Needed label.

@valhassan valhassan merged commit fd3eac8 into NRCan:develop Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: remove solaris
4 participants