Fix bugs found when parsing RTS-GMLC #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/devices/areas.jl
Outdated
| @@ -13,15 +13,15 @@ function get_components_to_pm(sys::PSY.System, ::Type{T}) where {T <: PSY.Area} | |||
| # get largest gen bus | |||
| pv_buses = [b for b in buses if PSY.get_bustype(b) == PSY.BusTypes.PV] | |||
| gens = PSY.get_components(PSY.Generator, sys, x -> PSY.get_bus(x) ∈ pv_buses) | |||
| ref_bus = last(sort(collect(gens), by = x -> PSY.get_max_active_power(x))) | |||
| ref_bus = PSY.get_bus(last(sort(collect(gens), by = x -> PSY.get_max_active_power(x)))) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| ref_bus = PSY.get_bus(last(sort(collect(gens), by = x -> PSY.get_max_active_power(x)))) | |
| ref_bus = PSY.get_bus( | |
| last(sort(collect(gens), by = x -> PSY.get_max_active_power(x))), | |
| ) |
daniel-thom
force-pushed
the
dt/bug-fixes
branch
from
10929f6
to
334389b
Compare
|
@claytonpbarrows Unit tests on the master branch failed locally for the same reasons as CI. Do you know what's going on? |
|
This happened: lanl-ansi/PowerModels.jl#798 |
test/test_wrapper.jl
Outdated
| return pm_data, pmi_data | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
test/test_wrapper.jl
Outdated
Comment on lines
12
to
15
| #TODO: remove the following for loop once PM#v0.20.0 is tagged | ||
| for id in keys(pmi_data["bus"]) | ||
| pm_data["bus"][id] = pmi_data["bus"][id] | ||
| end |
There was a problem hiding this comment.
@daniel-thom this is the short term hack that fixes the parsing discrepancy between PM and PSY that is planned to be addressed in PM#0.20.0
Codecov Report
@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 68.06% 77.38% +9.32%
==========================================
Files 8 8
Lines 263 252 -11
==========================================
+ Hits 179 195 +16
+ Misses 84 57 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.