Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AVR ST6B #388

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Add AVR ST6B #388

merged 7 commits into from
Sep 5, 2024

Conversation

SebastianManriqueM
Copy link
Contributor

Required for Honduras Project

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Performance Results

Version Precompile Time
Main 2.058988286
This Branch 2.059540413
Version Execute Time
Main-Build ResidualModel 7.962067824
Main-Execute ResidualModel 17.3640975
Main-Build MassMatrixModel 0.636106571
Main-Execute MassMatrixModel 32.369111027
This Branch-Build ResidualModel 7.196132405
This Branch-Execute ResidualModel 17.233314801
This Branch-Build MassMatrixModel 0.666423837
This Branch-Execute MassMatrixModel 33.028937306

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.80%. Comparing base (c94d006) to head (acc55d6).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...rc/initialization/generator_components/init_avr.jl 90.47% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   87.36%   86.80%   -0.57%     
==========================================
  Files          65       66       +1     
  Lines        9143     9561     +418     
==========================================
+ Hits         7988     8299     +311     
- Misses       1155     1262     +107     
Flag Coverage Δ
unittests 86.80% <96.77%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/models/generator_models/avr_models.jl 99.20% <100.00%> (+0.11%) ⬆️
src/post_processing/post_proc_generator.jl 90.28% <100.00%> (+1.13%) ⬆️
...rc/initialization/generator_components/init_avr.jl 94.91% <90.47%> (-0.57%) ⬇️

... and 5 files with indirect coverage changes

@rodrigomha rodrigomha merged commit 0c375d2 into main Sep 5, 2024
8 of 9 checks passed
rodrigomha pushed a commit that referenced this pull request Sep 9, 2024
* add mass matrix entries for ST6B

* Add Comment

* Add ST6B model

* Add initialization for ST6B

* add mass matrix entries for ST6B

* Add Test 59

* Fix Typo

---------

Co-authored-by: Machado <smachado@nrel.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants