Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wpidhy #391

Merged
merged 12 commits into from
Sep 19, 2024
Merged

Add wpidhy #391

merged 12 commits into from
Sep 19, 2024

Conversation

SebastianManriqueM
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Sep 17, 2024

Performance Results

Version Precompile Time
Main 1.958772251
This Branch 1.9383795
Version Execute Time
Main-Build ResidualModel 7.068904888
Main-Execute ResidualModel 16.182572961
Main-Build MassMatrixModel 0.605906103
Main-Execute MassMatrixModel 32.13381909
This Branch-Build ResidualModel 7.12088054
This Branch-Execute ResidualModel 16.590647968
This Branch-Build MassMatrixModel 0.622127018
This Branch-Execute MassMatrixModel 32.564164512

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 97.88732% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.99%. Comparing base (c94d006) to head (a4f6320).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/initialization/generator_components/init_tg.jl 95.31% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
- Coverage   87.36%   86.99%   -0.38%     
==========================================
  Files          65       66       +1     
  Lines        9143     9702     +559     
==========================================
+ Hits         7988     8440     +452     
- Misses       1155     1262     +107     
Flag Coverage Δ
unittests 86.99% <97.88%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/models/common_controls.jl 30.85% <100.00%> (+3.59%) ⬆️
src/models/generator_models/tg_models.jl 100.00% <100.00%> (ø)
src/post_processing/post_proc_generator.jl 90.61% <100.00%> (+1.46%) ⬆️
src/initialization/generator_components/init_tg.jl 95.95% <95.31%> (+0.16%) ⬆️

... and 3 files with indirect coverage changes

@rodrigomha rodrigomha self-requested a review September 18, 2024 23:11
@rodrigomha rodrigomha merged commit c97be58 into main Sep 19, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants