Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kLa calculation with uncertainty #90

Merged
merged 5 commits into from
Feb 4, 2025
Merged

kLa calculation with uncertainty #90

merged 5 commits into from
Feb 4, 2025

Conversation

malihass
Copy link
Collaborator

@malihass malihass commented Feb 4, 2025 •
edited
Loading

Add a tool to compute kla with uncertainty estimates

  • Dynamic removal early data if need be

Without removal
573cd904-bfb3-42a0-868b-fa7c401eead8

with removal

198ee013-f11d-47ce-b453-ab2f85ec73d6

  • Data bootstrapping (a bit handwavy for now)
  • Do the fit with bayesian calibration to get uncertainty estimates
  • Add tests

@malihass malihass marked this pull request as draft February 4, 2025 15:48
@malihass malihass requested review from hsitaram and mjrahimi February 4, 2025 17:05
@malihass malihass marked this pull request as ready for review February 4, 2025 17:05
mjrahimi
mjrahimi approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@mjrahimi mjrahimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mjrahimi
Copy link
Collaborator

mjrahimi commented Feb 4, 2025

I tested this and it works great. Could you add a comment there to explain the difference between with and without data bootstrap kLa result.

@malihass malihass merged commit fcedc60 into main Feb 4, 2025
9 checks passed
@malihass malihass deleted the klacalc branch February 4, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjrahimi mjrahimi mjrahimi approved these changes

@hsitaram hsitaram Awaiting requested review from hsitaram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malihass @mjrahimi