Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Library serralizer #202

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Fix Library serralizer #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions buildingmotif/api/serializers/library.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from typing_extensions import TypedDict

from buildingmotif.database.tables import DBLibrary
from buildingmotif.database.tables import DBLibrary, DBTemplate

LibraryDict = TypedDict(
"LibraryDict",
Expand Down Expand Up @@ -43,9 +43,11 @@ def _serialize(library: DBLibrary) -> LibraryDict:
:return: serialized library
:rtype: LibraryDict
"""
templates: List[DBTemplate] = library.templates # apleasing the type checker.

return {
"id": library.id,
"name": library.name,
"template_ids": library.templates,
"template_ids": [t.id for t in templates],
"shape_collection_id": library.shape_collection_id,
}
1 change: 1 addition & 0 deletions tests/unit/api/test_library.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ def test_get_all_libraries(client, building_motif):
def test_get_library(client, building_motif):
# Setup
lib = Library.create("my_library")
lib.create_template("my_template")

# Act
results = client.get(f"/libraries/{lib.id}")
Expand Down