-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote libraries (and bulk library loading) #213
Conversation
… gtf-remote-libraries
Codecov ReportBase: 73.54% // Head: 72.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #213 +/- ##
===========================================
- Coverage 73.54% 72.71% -0.83%
===========================================
Files 31 31
Lines 2026 2056 +30
===========================================
+ Hits 1490 1495 +5
- Misses 536 561 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. A few questions and comments.
- What's the benefit of using a YML file vs. passing local dirs or remote repos as CLI arguments?
- Why were the changes to
docs/tutorials/tutorial3_model.ttl
required? - Do we need to track
output.ttl
, which changes every time the223PExample.ipynb
is run (e.g. when integration test are run)?
Should the base branch = |
Thanks for the review, @MatthewSteen ! Here's some answers:
Not needed! Removed
Nope :). I've removed it and also added a gitignore rule |
It's looking pretty good. can we get some docs on the format this yaml should be in maybe? |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks Gabe!
I've created a simple
buildingmotif
CLI tool for loading libraries into a buildingmotif instance from alibraries.yml
file. POC is in the attached screenshot. Address #207 and is one answer to #133 (unless I'm misinterpreting that issue?)I will definitely need to add some documentation on the
libraries.yml
format and how the CLI tool works, but what do you all think of the solution so far?@TShapinsky @MatthewSteen @haneslinger