-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 223P Templates #225
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #225 +/- ##
========================================
Coverage 72.75% 72.75%
========================================
Files 32 32
Lines 2063 2063
========================================
Hits 1501 1501
Misses 562 562 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking good. See my comment
2ca836e
to
eed1a3d
Compare
…OTIF into gtf-update-223p-templates
…OTIF into gtf-update-223p-templates
…OTIF into gtf-update-223p-templates
@MatthewSteen I made a change to the |
@gtfierro the new docs uses sphinx (via jupyter book) for versions docs so make sure you're using whatever is on develop. I'm flying so will check later. |
…OTIF into gtf-update-223p-templates
I've made a note of future changes to 223P to support G36 concepts:
s223:HeatExchanger-Cooling/Heating
not defined? (what are the right roles?)s223:Role-HeatExchanger
not defined but mentioned unders223:HeatExchanger
connectsThrough
->connectsAt
)s223:MeasuredPropertyRule
supposed to work? It seems to fire unnecessarily and add blank node properties everywhere -- does it need a condition?I've added temporary fixes to 223P.ttl here so that our templates are valid. I recommend we merge this in w/o the changes pushed to 223P so that we're not dependent upon an external timeline.