Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CD cleanup #226

Merged
merged 17 commits into from
Mar 1, 2023
Merged

CD cleanup #226

merged 17 commits into from
Mar 1, 2023

Conversation

MatthewSteen
Copy link
Member

@MatthewSteen MatthewSteen commented Feb 28, 2023

Close #220.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1022f09) 73.54% compared to head (04145c0) 73.54%.

❗ Current head 04145c0 differs from pull request most recent head a9d74b0. Consider uploading reports for the commit a9d74b0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #226   +/-   ##
========================================
  Coverage    73.54%   73.54%           
========================================
  Files           31       31           
  Lines         2026     2026           
========================================
  Hits          1490     1490           
  Misses         536      536           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@gtfierro gtfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So clean!

I'm ok with merging this once the tests are fixed

Copy link
Member

@TShapinsky TShapinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Are the failing style tests a cause for concern?

@MatthewSteen
Copy link
Member Author

MatthewSteen commented Mar 1, 2023

This looks good to me. Are the failing style tests a cause for concern?

@TShapinsky no, that's CI-related and is from the docs/conf.py, which should be skipped as included in the pylama.ini, but I haven't figured out the cause yet. Will be working on it and doing some more work in the CI cleanup PR.

@MatthewSteen MatthewSteen merged commit 9d8f265 into develop Mar 1, 2023
@MatthewSteen MatthewSteen deleted the cd-cleanup branch March 1, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup CD workflow
4 participants