Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use poetry 1.4.0 #233

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Use poetry 1.4.0 #233

merged 4 commits into from
Mar 23, 2023

Conversation

haneslinger
Copy link
Collaborator

gtfierro
gtfierro approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@gtfierro gtfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran into this issue!

@gtfierro gtfierro mentioned this pull request Mar 23, 2023
Merged
1 task
MatthewSteen
MatthewSteen approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@MatthewSteen MatthewSteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Do we need NRELAdmin review?

@MatthewSteen MatthewSteen self-requested a review March 23, 2023 15:38
@gtfierro
Copy link
Collaborator

Thanks. Do we need NRELAdmin review?

I don't think so...

MatthewSteen
MatthewSteen approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@MatthewSteen MatthewSteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot we should always update the docs too.

@haneslinger haneslinger merged commit fd49343 into develop Mar 23, 2023
@haneslinger haneslinger deleted the Use-poetry-1.4.0 branch March 23, 2023 16:24
@MatthewSteen MatthewSteen removed the request for review from NRELAdmin March 27, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtfierro gtfierro gtfierro approved these changes

@TShapinsky TShapinsky TShapinsky approved these changes

@MatthewSteen MatthewSteen MatthewSteen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haneslinger @gtfierro @TShapinsky @MatthewSteen