Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failed shape and component to GraphDiff object #243

Merged
merged 1 commit into from
May 19, 2023

Conversation

gtfierro
Copy link
Collaborator

By including the shape and components that failed in the GraphDiff objects, it becomes possible to generate more useful user messages. I will also need this information to be present for better interpretation of GraphDiff objects for automatically repairing a Model

By including the shape and components that failed in the GraphDiff
objects, it becomes possible to generate more useful user messages. I
will also need this information to be present for better interpretation
of GraphDiff objects for automatically repairing a Model
Copy link
Member

@TShapinsky TShapinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Gabe.

@gtfierro gtfierro merged commit 5438f17 into develop May 19, 2023
@gtfierro gtfierro deleted the add-failed-shape-to-diffset branch May 19, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants