-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hannah eval ingress #244
Hannah eval ingress #244
Conversation
haneslinger
commented
May 17, 2023
…mespace is consistent between the input/output
Not enforcing Namespace type on ingress.graph() would result in the evaluation silently coercing URIs to strings; this is covered with an assertion. Also fixing up some type annotations and spellings too
…n failed test too
I'm having a hard time testing this because I keep running into that database migration error on the |
I'm not having these issues and am having trouble remembering... can you elaborate? |
#247 addresses the issue that I'm running into -- I should be able to use that to test this PR early next week |
@haneslinger I'm finally getting around to this (so sorry! Travel put me behind on everything). Is the "choose file" dialog intended to let me upload a CSV file for evaluating the template? (I'm referring to hitting the Template evaluation endpoint code path)? When I upload a CSV file using the new interface, I get these errors: The final error suggests to me that maybe the CSV file is being added to the graph directly (and then it is complaining about incorrect syntax) rather than put through the template evaluation endpoint. The CSV file itself is just:
I tried reading through the code to see how the template evaluation code was invoked. I think that the file is uploaded to the template evaluation endpoint and the graph is stored in a |