Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hannah eval ingress #244

Merged
merged 11 commits into from
Jul 24, 2023
Merged

Hannah eval ingress #244

merged 11 commits into from
Jul 24, 2023

Conversation

haneslinger
Copy link
Collaborator

image

@gtfierro
Copy link
Collaborator

I'm having a hard time testing this because I keep running into that database migration error on the deps_association table that we talked about awhile ago. Do you get this locally too, or is there a particular process you use to set up the DB? I'm just using the docker compose file we have

@haneslinger
Copy link
Collaborator Author

I'm having a hard time testing this because I keep running into that database migration error on the deps_association table that we talked about awhile ago. Do you get this locally too, or is there a particular process you use to set up the DB? I'm just using the docker compose file we have

I'm not having these issues and am having trouble remembering... can you elaborate?

@gtfierro
Copy link
Collaborator

#247 addresses the issue that I'm running into -- I should be able to use that to test this PR early next week

@gtfierro
Copy link
Collaborator

@haneslinger I'm finally getting around to this (so sorry! Travel put me behind on everything). Is the "choose file" dialog intended to let me upload a CSV file for evaluating the template? (I'm referring to hitting the Template evaluation endpoint code path)? When I upload a CSV file using the new interface, I get these errors:

Screenshot 2023-06-12 at 8 00 11 PM

The final error suggests to me that maybe the CSV file is being added to the graph directly (and then it is complaining about incorrect syntax) rather than put through the template evaluation endpoint.

The CSV file itself is just:

name
def
zyx

I tried reading through the code to see how the template evaluation code was invoked. I think that the file is uploaded to the template evaluation endpoint and the graph is stored in a evaluatedGraph variable, but then this value is never used again. Can you take a look?

@haneslinger
Copy link
Collaborator Author

The final error suggests to me that maybe the CSV file is being added to the graph directly (and then it is complaining about incorrect syntax) rather than put through the template evaluation endpoint.

I am not getting this error nor am I trying to add the csv to the graph directly (note /templates/861/evaluate/ingress?model_id=3 was called, which does not modify anything in the db.)

image

Could you look at the api logs and get a stack trace for your error?

@haneslinger haneslinger changed the title Hannah fix eval ingress test Hannah eval ingress Jul 10, 2023
@haneslinger haneslinger requested a review from TShapinsky July 24, 2023 20:06
@haneslinger haneslinger merged commit 67bbeaf into develop Jul 24, 2023
@haneslinger haneslinger deleted the hannah-fix-eval-ingress-test branch July 24, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants