-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove configs.py #256
Remove configs.py #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one suggestion and needs a test fix.
Co-authored-by: Matt Steen <MatthewSteen@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we could also consider incorporating or linking to python-dotenv which automatically brings in a .env file as environment variables https://pypi.org/project/python-dotenv/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me once tests pass and it's merged
|
@MatthewSteen re-pinging this. |
@haneslinger I think this just needs some brief documentation about the BASH requirement to run on Windows. See my comments and suggestions above, specifically #256 (comment).
|
@MatthewSteen Oh, yes, thank you. Would you be able to add that? Do you want it in this PR? |
@haneslinger I added a note for windows users, which I think is sufficient for now. Take a look and merge when ready. |
We dont need this anymore, we've got
.env