-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spreadsheet generation for templates #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I CANT BELIEVE YOUVE DONE THIS.
thanks gabe
I broke out tests for spreadsheet and CSV generation. It's not currently testing the write-directly-to-file path but I'd like to find a way to avoid duplicating all the test logic to handle that |
Move template generation tests to their own file
Tests are now parameterized and a fair bit cleaner in their implementation. I should be touching all of the codepaths as well. This is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I needed to implement this for a demo so here's a first cut at it
Generates a spreadsheet like this: