EUSS measure package tests #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
address dispatch window on last day exceed year end
asparke2
approved these changes
Feb 15, 2024
| weighted_thermostat_heating_max_c += heat_min_max['max'] * floor_area_m2 | ||
| weighted_thermostat_heating_area_m2 += floor_area_m2 | ||
| if thermostat_heating_schedule.to_ScheduleRuleset.is_initialized | ||
| puts("--- Ruleset schedule") |
There was a problem hiding this comment.
Get rid of "puts" statements throughout.
There was a problem hiding this comment.
This is the same as compare_upgrades.py.template with some marley-specific run paths. Remove this file from PR
| @@ -935,6 +935,90 @@ results.csv,qoi_report.average_of_top_ten_highest_peaks_timing_winter_hour,,FALS | |||
| results.csv,qoi_report.average_of_top_ten_highest_peaks_use_shoulder_kw,,FALSE,FALSE,float,kw,kw,Average hourly top 10 highest electric peaks during shoulder season | |||
| results.csv,qoi_report.average_of_top_ten_highest_peaks_use_summer_kw,,FALSE,FALSE,float,kw,kw,Average hourly top 10 highest electric peaks during summer | |||
| results.csv,qoi_report.average_of_top_ten_highest_peaks_use_winter_kw,,FALSE,FALSE,float,kw,kw,Average hourly top 10 highest electric peaks during winter | |||
| results.csv,qoi_report.minimum_daily_peak_jan_kw,out.qoi.minimum_daily_peak_jan,TRUE,FALSE,float,kw,kw,Minimum hourly daily electric load peak during January | |||
There was a problem hiding this comment.
Will need to turn off the variability columns that were needed for debugging but not desired in full published output.
There was a problem hiding this comment.
This file is the same as compare_upgrades.py.template, remove from PR.
| @@ -94,7 +94,6 @@ def arguments(model) | |||
| year = OpenStudio::Measure::OSArgument.makeStringArgument('year', true) | |||
| year.setDisplayName('Weather File Year') | |||
| year.setDescription('Year of the weather file to use.') | |||
| year.setDefaultValue('2018') | |||
There was a problem hiding this comment.
@ChristopherCaradonna in the test run, include the simulation settings check reporting measure to confirm that we are still running in 2018 and getting the expected timeseries.
| @@ -0,0 +1,206 @@ | |||
| # insert your copyright here | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Merges all EUSS cycle 3 changes.
Pull Request Author: Chris CaraDonna
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csvoptions_lookup.tsvfiles updated.ymlfilesREADME.mdfilestest/measure_tests.txtor/andtest/resource_measure_tests.txtReview Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File