Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alaska and Hawaii to sampling #123

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Conversation

amylebar
Copy link
Contributor

@amylebar amylebar commented Feb 17, 2024

Pull request overview

  • Added Alaska and Hawaii county names and ResStock PUMA names. This will more easily allow Alaska and Hawaii to be included in analyses with ComStock results, including on the data viewer and tableau dashboards
  • Saved a new version of the lookup file: spatial_tract_lookup_table_publish_v6.csv
  • Deleted v4 and v5 to clean up the directory
  • 350k sampling and geospatial join was successful

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes singularity image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

- added alaska and hawaii county names and resstock puma names, and saved a new version of `spatial_tract_lookup_table_publish_v6.csv`
- deleted v4 and v5 to clean up the directory
@amylebar amylebar added sampling PR improves or adds to the sampling methodology Pull Request - Ready for CI labels Feb 17, 2024
Copy link
Collaborator

@rHorsey rHorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catches - many thanks @amylebar !

@rHorsey rHorsey merged commit f02cc24 into main Feb 17, 2024
0 of 3 checks passed
@rHorsey rHorsey deleted the sampling_ak_hi_county_names branch February 17, 2024 21:52
@mdahlhausen mdahlhausen changed the title Add Alaska and Hawaii county names to sampling Add Alaska and Hawaii to sampling Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request - Ready for CI sampling PR improves or adds to the sampling methodology
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants