Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create typical measure unit test fixes #132

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Create typical measure unit test fixes #132

merged 2 commits into from
Mar 6, 2024

Conversation

mpraprost
Copy link
Contributor

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF RELEVANT)

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes singularity image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

unit test fixes
96bd98d 
- rename out of date method
- remove temporary code to fix indoor pipe ambient temps (fixed by NREL/EnergyPlus#9650)
@mpraprost mpraprost added the workflow measure PR improves or adds baseline workflow measures label Mar 6, 2024
@mdahlhausen
Copy link
Contributor

@mpraprost update the measure .xml please :)

@mdahlhausen mdahlhausen merged commit 27290a0 into fix/unit_tests Mar 6, 2024
0 of 2 checks passed
@mdahlhausen mdahlhausen deleted the create_typical_unit_tests branch March 6, 2024 20:42
@mdahlhausen mdahlhausen changed the title unit test fixes Create typical measure unit test fixes Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdahlhausen mdahlhausen mdahlhausen approved these changes

Assignees

@mdahlhausen mdahlhausen

Labels
Pull Request - Ready for CI workflow measure PR improves or adds baseline workflow measures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpraprost @mdahlhausen