Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure unit test fixes #134

Merged
merged 9 commits into from
Mar 11, 2024
Merged

Measure unit test fixes #134

merged 9 commits into from
Mar 11, 2024

Conversation

eringold
Copy link
Contributor

@eringold eringold commented Mar 6, 2024

Pull request overview

Fixes failing tests for:

  • ChangeBuildingLocation
  • upgrade_env_roof_insulation_aedg
  • EnvStormWindowsTest (measure did not exist)
  • upgrade_hvac_economizer

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes singularity image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

@eringold eringold added workflow measure PR improves or adds baseline workflow measures Pull Request - Ready for CI labels Mar 7, 2024
Copy link
Contributor

@mdahlhausen mdahlhausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eringold I'm getting some failures on the upgrade_env_new_aedg_windows measure tests. Also one failure on the hvac_economizer_test.rb. I'm running it with OS 3.6.1 on a windows machine. in The rest of the tests are running fine.

@eringold
Copy link
Contributor Author

eringold commented Mar 9, 2024

@mdahlhausen:
@ChristopherCaradonna claimed upgrade_env_new_aedg_windows, I just updated the xml because I deleted the erroneously-placed EnvStormWindowsTest from that measure's test dir.

Re: hvac_economizer_test, I see all tests passing with OS 3.7.0, using openstudio cli:
image
...
image
Which test did you see failing? Were you running with system Ruby or with openstudio?

@mdahlhausen mdahlhausen self-requested a review March 11, 2024 17:20
@mdahlhausen
Copy link
Contributor

@eringold it runs in 3.7, not 3.6.1. good to merge since we are running ComStock with OS 3.7

@mdahlhausen mdahlhausen merged commit 72a68f5 into main Mar 11, 2024
@mdahlhausen mdahlhausen deleted the eringold/test_fix branch March 11, 2024 17:32
@mdahlhausen mdahlhausen changed the title Unit test fixes Measure unit test fixes Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request - Ready for CI workflow measure PR improves or adds baseline workflow measures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants