-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measure unit test fixes #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eringold I'm getting some failures on the upgrade_env_new_aedg_windows measure tests. Also one failure on the hvac_economizer_test.rb. I'm running it with OS 3.6.1 on a windows machine. in The rest of the tests are running fine.
@mdahlhausen: Re: hvac_economizer_test, I see all tests passing with OS 3.7.0, using openstudio cli: |
@eringold it runs in 3.7, not 3.6.1. good to merge since we are running ComStock with OS 3.7 |
Pull request overview
Fixes failing tests for:
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/measure_tests.txt
or/andtest/resource_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File