Fix issues in the resources/measure test #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some of the measure under resources/ has been renamed and hasn't been updated in the resource_measure_test.txt . (for example: dfd5efe)
And some new measure test has been added without import the test_helper(for example: https://github.com/NREL/ComStock/blame/main/resources/measures/create_typical_building_from_model/tests/test_hvac.rb)
the measure test result cannot be executed correctly in docker and ci, the missing file in the resource_measure_test.txt will cause the rake test cannot continue since it cannot find the file.
For example:
https://ci.openstudio.net/blue/organizations/jenkins/comstock-internal/detail/main/33/pipeline/49
You will notice the
run resources measure tests
report as success but actually it cannot Archiving artifacts due to rake execution aborted.This PR is basically fix this issue by:
Update the resource_measure_test.txt
Go through the measures under /resource/ and import the ../../../../test/helpers/minitest_helper if it hasn't been done to support generating junit xml report.
Fixes #ISSUENUMBERHERE (IF RELEVANT)
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/measure_tests.txt
or/andtest/resource_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File