Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in the resources/measure test #135

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Conversation

wenyikuang
Copy link
Collaborator


Since some of the measure under resources/ has been renamed and hasn't been updated in the resource_measure_test.txt . (for example: dfd5efe)
And some new measure test has been added without import the test_helper(for example: https://github.com/NREL/ComStock/blame/main/resources/measures/create_typical_building_from_model/tests/test_hvac.rb)
the measure test result cannot be executed correctly in docker and ci, the missing file in the resource_measure_test.txt will cause the rake test cannot continue since it cannot find the file.
For example:
https://ci.openstudio.net/blue/organizations/jenkins/comstock-internal/detail/main/33/pipeline/49

You will notice the run resources measure tests report as success but actually it cannot Archiving artifacts due to rake execution aborted.

This PR is basically fix this issue by:

  • Update the resource_measure_test.txt

  • Go through the measures under /resource/ and import the ../../../../test/helpers/minitest_helper if it hasn't been done to support generating junit xml report.

  • Fixes #ISSUENUMBERHERE (IF RELEVANT)

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes singularity image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

@wenyikuang wenyikuang added infrastructure PR improves or updates the build process and dependencies upgrade measure PR improves or adds upgrade measures Pull Request - Ready for CI labels Mar 7, 2024
@wenyikuang wenyikuang added the bug Something isn't working label Mar 8, 2024
@asparke2 asparke2 merged commit 61f4bcb into main Mar 19, 2024
0 of 3 checks passed
@asparke2 asparke2 deleted the wenyi/measure-test-debug branch March 19, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure PR improves or updates the build process and dependencies Pull Request - Ready for CI upgrade measure PR improves or adds upgrade measures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants