Aggregate the error summaries per each upgrade. #248
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyikuang
commented
Nov 1, 2024
| if line not in alLines: | ||
| alLines.append(line) | ||
| #delete the file | ||
| # os.remove(os.path.join(path, file)) |
There was a problem hiding this comment.
If you don't want to keep the err_summary per each upgrade, just uncomment this line.
wenyikuang
commented
Nov 1, 2024
| @@ -545,14 +546,14 @@ def load_data(self, upgrade_id, acceptable_failure_percentage=0.01, drop_failed_ | |||
| # Fill Nulls in measure-within-upgrade applicability columns with False | |||
| for c, dt in up_res.schema.items(): | |||
| if 'applicable' in c: | |||
| if dt == pl.Null: | |||
| if dt == pl.Null or dt == pl.Boolean: | |||
There was a problem hiding this comment.
Small patch to handle the case when type of column is pl.Boolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csvoptions_lookup.tsvfiles updated.ymlfilesREADME.mdfilestest/measure_tests.txtor/andtest/resource_measure_tests.txtReview Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File