-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utility bill calculations #71
Conversation
with open(args.kwhpath) as f: | ||
for val in f: | ||
hourly_kwh.append(float(val)) | ||
assert len(hourly_kwh) == 8760, f"Got {len(hourly_kwh)} instead of expected 8760 hourly kWh values" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how will you account for leap years?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ComStock runs the first 365 days of the year for leap years, so it cuts off Dec 31st when there is a leap year, always leaving 8760 hours worth of timeseries data
measures/utility_bills/measure.rb
Outdated
result = OpenStudio::IdfObjectVector.new | ||
|
||
# Request hourly data for fuel types with hourly bill calculations | ||
fuel_types = ['Electricity'] # 'NaturalGas', 'DistrictCooling', 'DistrictHeating', 'FuelOilNo2', 'Propane' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are other fuel types commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need hourly data for electricity bill calculations, the other fuels are all currently annual volumetric prices.
Other comments:
|
# Conflicts: # postprocessing/comstockpostproc/comstock.py
@eringold @mdahlhausen made another two fixes and ran:
Result: |
Pull request overview
This pull request adds utility bill calculations for electricity, natural gas, propane, and fuel oil. Electricity rates are from the U.S. Utility Rate Database on OpenEI. Petroleum fuel rates are volumetric prices derived from EIA data. All bills reflect 2022 prices.
See change documentation here: https://nrel.sharepoint.com/:w:/r/sites/comstock/Shared%20Documents/ComStock%20Filing%20Cabinet/ComStock%20Core/Change%20Documentation/Changes/vTBD%20Utility%20Rates/ComStock%20Change%20Adds%20Utility%20Rates.docx?d=w1dbdbc340bec4de9a6234a3d05a9345c&csf=1&web=1&e=teBIKO
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filesReview Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File