-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kaleido version #89
Conversation
cb48d99
to
f9a7006
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested on Windows. The correct .post1
version of Kaleido gets installed and the QOI plots (which use Kaleido via plotly) work fine. @wenyikuang can you confirm that the QOI plots generate correctly on Linux?
Sure. |
FYI i'm trying this out on a postproc run on Eagle now. |
@wenyikuang @asparke2 with this change on Eagle I was able to update the postproc env and successfully generate the QOI plots for my recent run: |
Thank you @eringold , then I believe it's good to merge. |
34a93ac
to
f9a7006
Compare
When I was testing the ci building. I found the Kaleido==0.1.0post1 has been removed from the pip resource.
Click the python unittest
you could find the issue:
And when I tested local I could:
No matter keleido==0.1.0post1
or
kelido==0.1.0.post1 (which is following their website: https://pypi.org/project/kaleido/#history)
Are not able to be found.
I believe the most clostest thing should be
kaleido==0.1.0
. And it works.Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filesReview Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File
Comment: could be the first issue found with CI system. :)