Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kaleido version #89

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Update kaleido version #89

merged 1 commit into from
Jan 18, 2024

Conversation

wenyikuang
Copy link
Collaborator

@wenyikuang wenyikuang commented Jan 10, 2024

When I was testing the ci building. I found the Kaleido==0.1.0post1 has been removed from the pip resource.

Click the python unittest

you could find the issue:

ERROR: Could not find a version that satisfies the requirement kaleido==0.1.0post1 (from comstock-postprocessing[dev]) (from versions: 0.0.1rc3, 0.0.1rc4, 0.0.1rc5, 0.0.1rc6, 0.0.1rc8, 0.0.1rc9, 0.0.1, 0.0.2, 0.0.3, 0.0.3.post1, 0.1.0a2, 0.1.0a3, 0.1.0, 0.2.0rc1, 0.2.0, 0.2.1)

ERROR: No matching distribution found for kaleido==0.1.0post1


And when I tested local I could:
No matter keleido==0.1.0post1

root@785d5fa86239:/App3/ComStock/postprocessing# pip3 install kaleido==0.1.0post1
WARNING: Ignoring invalid distribution -aleido (/usr/local/lib/python3.8/dist-packages)
WARNING: Ignoring invalid distribution -aleido (/usr/local/lib/python3.8/dist-packages)
ERROR: Could not find a version that satisfies the requirement kaleido==0.1.0post1 (from versions: 0.0.1rc3, 0.0.1rc4, 0.0.1rc5, 0.0.1rc6, 0.0.1rc8, 0.0.1rc9, 0.0.1, 0.0.2, 0.0.3, 0.0.3.post1, 0.1.0a2, 0.1.0a3, 0.1.0, 0.2.0rc1, 0.2.0, 0.2.1)
ERROR: No matching distribution found for kaleido==0.1.0post1

or
kelido==0.1.0.post1 (which is following their website: https://pypi.org/project/kaleido/#history)

root@785d5fa86239:/App3/ComStock/postprocessing# pip3 install kaleido==0.1.0.post1
WARNING: Ignoring invalid distribution -aleido (/usr/local/lib/python3.8/dist-packages)
WARNING: Ignoring invalid distribution -aleido (/usr/local/lib/python3.8/dist-packages)
ERROR: Could not find a version that satisfies the requirement kaleido==0.1.0.post1 (from versions: 0.0.1rc3, 0.0.1rc4, 0.0.1rc5, 0.0.1rc6, 0.0.1rc8, 0.0.1rc9, 0.0.1, 0.0.2, 0.0.3, 0.0.3.post1, 0.1.0a2, 0.1.0a3, 0.1.0, 0.2.0rc1, 0.2.0, 0.2.1)
ERROR: No matching distribution found for kaleido==0.1.0.post1
WARNING: Ignoring invalid distribution -aleido (/usr/local/lib/python3.8/dist-packages)
WARNING: Ignoring invalid distribution -aleido (/usr/local/lib/python3.8/dist-packages)
WARNING: Ignoring invalid distribution -aleido (/usr/local/lib/python3.8/dist-packages)

[notice] A new release of pip is available: 23.0.1 -> 23.3.2
[notice] To update, run: python3 -m pip install --upgrade pip

Are not able to be found.

I believe the most clostest thing should be kaleido==0.1.0. And it works.


  • Fixes #ISSUENUMBERHERE (IF RELEVANT)

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes singularity image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

Comment: could be the first issue found with CI system. :)

@wenyikuang wenyikuang requested review from rHorsey and removed request for ChristopherCaradonna January 11, 2024 00:26
@asparke2 asparke2 self-assigned this Jan 11, 2024
@asparke2 asparke2 self-requested a review January 11, 2024 14:19
asparke2
asparke2 previously approved these changes Jan 11, 2024
Copy link
Member

@asparke2 asparke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on Windows. The correct .post1 version of Kaleido gets installed and the QOI plots (which use Kaleido via plotly) work fine. @wenyikuang can you confirm that the QOI plots generate correctly on Linux?

@wenyikuang
Copy link
Collaborator Author

Sure.

@eringold
Copy link
Contributor

FYI i'm trying this out on a postproc run on Eagle now.

@eringold
Copy link
Contributor

@wenyikuang @asparke2 with this change on Eagle I was able to update the postproc env and successfully generate the QOI plots for my recent run:
site_eui_savings_by_climate_zone

@wenyikuang
Copy link
Collaborator Author

Thank you @eringold , then I believe it's good to merge.

@asparke2 asparke2 merged commit 15b58d0 into main Jan 18, 2024
@asparke2 asparke2 deleted the wenyi/updateKaleido branch January 18, 2024 21:30
wenyikuang added a commit that referenced this pull request Jan 24, 2024
@mdahlhausen mdahlhausen changed the title Update version of kaleido. Update kaleido version Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants