Report System Summary:Thermostat Schedules depends on order of ZoneControl:Thermostat control types

[JasonGlazer]

Issue overview

The Thermostat Schedules table which appears under the System Summary tabular report changes depending on the order of control types shown in ZoneControl:Thermostat even though the list is "not order dependent."

To reproduce choose an example file that has ZoneControl:Thermostats with multiple control types such as 5ZoneAirCooled_VAVBoxMinAirFlowTurnDown.idf

Change the order of control types:

  ZoneControl:Thermostat,
    SPACE2-1 Control,        !- Name
    SPACE2-1,                !- Zone or ZoneList Name
    Zone Control Type Sched, !- Control Type Schedule Name
    ThermostatSetpoint:SingleCooling,  !- Control 1 Object Type
    CoolingSetPoint,         !- Control 1 Name
    ThermostatSetpoint:SingleHeating,  !- Control 2 Object Type
    HeatingSetpoint,         !- Control 2 Name
    ThermostatSetpoint:DualSetpoint,  !- Control 3 Object Type
    DualSetPoint;            !- Control 3 Name

to

  ZoneControl:Thermostat,
    SPACE2-1 Control,        !- Name
    SPACE2-1,                !- Zone or ZoneList Name
    Zone Control Type Sched, !- Control Type Schedule Name
    ThermostatSetpoint:DualSetpoint,  !- Control 3 Object Type
    DualSetPoint,            !- Control 3 Name
    ThermostatSetpoint:SingleCooling,  !- Control 1 Object Type
    CoolingSetPoint,         !- Control 1 Name
    ThermostatSetpoint:SingleHeating,  !- Control 2 Object Type
    HeatingSetpoint;         !- Control 2 Name

The Thermostat Schedules table changes from:

to:

Details

Some additional details for this issue (if relevant):

• Tested on Windows 10
• EnergyPlus 24.2

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Defect file added (list location of defect file here)
• Ticket added to EnergyPlus Defect Complexity (Github Project)
• Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

[JasonGlazer]

Issue found during work on #10848

[jmarrec]

Another issue is that the SingleHeating and SingleCooling Tstat types have their schedule incorrectly reported as being the opposite (SingleHeating reports as Cooling Schedule, and Single Cooling as Heating)

EnergyPlus/src/EnergyPlus/ZoneTempPredictorCorrector.cc

Lines 7044 to 7052 in acda84e

	case HVAC::ThermostatType::SingleCooling:
	PreDefTableEntry(
	state, orp->pdchStatSchdHeatName, tcz.ZoneName, ScheduleManager::GetScheduleName(state, tcz.SchIndx_SingleCoolSetPoint));
	break;
	case HVAC::ThermostatType::SingleHeating:
	PreDefTableEntry(
	state, orp->pdchStatSchdCoolName, tcz.ZoneName, ScheduleManager::GetScheduleName(state, tcz.SchIndx_SingleHeatSetPoint));
	break;
	}

This test is equally wrong, so it passes:

EnergyPlus/tst/EnergyPlus/unit/ZoneTempPredictorCorrector.unit.cc

Lines 1855 to 1858 in acda84e

	EXPECT_EQ("SingleHeating", RetrievePreDefTableEntry(*state, orp.pdchStatSchdType1, "zoneA"));
	EXPECT_EQ("control A", RetrievePreDefTableEntry(*state, orp.pdchStatSchdTypeName1, "zoneA"));
	EXPECT_EQ("schA", RetrievePreDefTableEntry(*state, orp.pdchStatSchdCoolName, "zoneA"));
	EXPECT_EQ("NOT FOUND", RetrievePreDefTableEntry(*state, orp.pdchStatSchdHeatName, "zoneA"));