Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10923 - Quick fix Epl-run.bat #10932

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

#10923 - Quick fix Epl-run.bat #10932

wants to merge 1 commit into from

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Feb 10, 2025

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmarrec jmarrec added DoNotPublish Includes changes that shouldn't be reported in the changelog AuxiliaryTool Related to an auxiliary tool, not EnergyPlus itself (readvars, preprocessor, ep-launch, etc.) labels Feb 10, 2025
@jmarrec jmarrec self-assigned this Feb 10, 2025
@Myoldmopar
Copy link
Member

@jmarrec do you want @JasonGlazer to build a new EP-Launch (VB6) version for this?

And do we need to modify EP-Launch-3 (Python) to handle this also? If so, this is probably something in the workflows/ here in this repo, unless it's a GUI change.

@jmarrec
Copy link
Contributor Author

jmarrec commented Feb 10, 2025

I'm just doing a drive-thru fix here. Instead of letting it drag along, at least even without a button to open it up, it will be present in the run directory instead of plain missing. Took me 5min. This is not part of a defect ticket.

And yes, someone else should handle the vb6 side, I don't have a compiler handy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AuxiliaryTool Related to an auxiliary tool, not EnergyPlus itself (readvars, preprocessor, ep-launch, etc.) DoNotPublish Includes changes that shouldn't be reported in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants