Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder for desuperheater with water-to-air variable speed equation fit coil #10935

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

yzhou601
Copy link
Contributor

Pull request overview

  • Fixes #ISSUENUMBERHERE

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@yzhou601 yzhou601 self-assigned this Feb 10, 2025
@yzhou601 yzhou601 added NewFeature Includes code to add a new feature to EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) labels Feb 10, 2025
@yzhou601 yzhou601 added this to the EnergyPlus 25.1 IO Freeze milestone Feb 10, 2025
@yzhou601 yzhou601 marked this pull request as ready for review February 11, 2025 16:19
@yzhou601 yzhou601 requested a review from Myoldmopar February 11, 2025 16:19
@Myoldmopar
Copy link
Member

This can go in, no problem. It's tagged as a NewFeature labeled PR, but really it's not a new feature. When you make the actual implementation PR, let's tag that one NewFeature and try to remember to move this to DoNotPublish. Anyway, this is good, thanks.

@Myoldmopar Myoldmopar merged commit a4c1621 into develop Feb 13, 2025
10 of 11 checks passed
@Myoldmopar Myoldmopar deleted the Desuperheater_multispeed_watertoair_equationfit branch February 13, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) NewFeature Includes code to add a new feature to EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants