-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating GreenHEART Examples #30
Conversation
added plot to electrolyzer example for lifetime performance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I pushed some extremely minor changes directly to the PR.
All four of the example notebooks have some quasi-repetitive explanations in the first half of the notebooks. Is this on purpose for repetition, or is each notebook supposed to stand on its own? In the future for docs I'd suggest removing redundancies if not needed, but that's a later consideration.
Yeah there's definitely some repetition, would love to have a large discussion about how the examples should work i.e. if they should be stand-alone or not. I feel 50/50 on it myself. |
Clean up GreenHEART Examples
Related issue
Impacted areas of the software
Additional supporting information
Test results, if applicable