merge for v0.8.5 #125
Merged
merge for v0.8.5 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #85. - Added error for very short duration simulations - Added OCHREException to handle errors - Updated docs and added trademark logo - [x] Reference the issue your PR is fixing - [x] Assign at least 1 reviewer for your PR - [x] Test with run_dwelling.py or other script - [x] Update documentation as appropriate - [x] Update changelog as appropriate
We found a bug when running the `run_equipment.run_hvac` script. The envelope wasn't accounting for the heat delivered by the HVAC. The issue is in Equipment.py, and is addressed here. No issue created. - [x] Reference the issue your PR is fixing - [x] Assign at least 1 reviewer for your PR - [x] Test with run_dwelling.py or other script - [x] Update documentation as appropriate - [x] Update changelog as appropriate
This addresses 2 bugs related to assigning EV charging events: - The random seed wasn't working, because events were generated before the seed was set. This is fixed. - There was no way to specify the event data, for example using the same events for Level 1/Level 2 chargers. The event data file is now an input. No assigned issue. @JingWang-CUB raised this privately (see panel-tea branch). - [x] Reference the issue your PR is fixing - [x] Assign at least 1 reviewer for your PR - [x] Test with run_dwelling.py or other script - [x] Update documentation as appropriate - [x] Update changelog as appropriate
jmaguire1
reviewed
Jun 3, 2024
jmaguire1
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging dev into main for v0.8.5