120V HPWH #134
Draft
120V HPWH #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnblonsky
reviewed
Aug 28, 2024
| self.cop_coeff = np.array([1.1332, 0.063, -0.0000979, -0.00972, -0.0000214, -0.000686]) | ||
| if self.low_power_hpwh: | ||
| self.hp_capacity_coeff = np.array([0.813, 0.0160, 0.000537, 0.0020319, -0.0000860, -0.0000686]) | ||
| self.cop_coeff = np.array([1.1332, 0.063, -0.0000979, -0.00972, -0.0000214, -0.000686]) |
There was a problem hiding this comment.
Can you double check this? Looks like you copied the existing capacity values
to the normal HPWH, but the existing COP values to the low power HPWH.
There was a problem hiding this comment.
Good call, but this is actually up to date (ie different) in the latest version?
OCHRE/ochre/Equipment/WaterHeater.py
Line 462 in b781132
mnblonsky
reviewed
Aug 28, 2024
ochre/Equipment/WaterHeater.py
Outdated
| @@ -413,8 +413,12 @@ class HeatPumpWaterHeater(ElectricResistanceWaterHeater): | |||
| def __init__(self, hp_only_mode=False, water_nodes=12, **kwargs): | |||
| super().__init__(water_nodes=water_nodes, **kwargs) | |||
|
|
|||
| self.low_power_hpwh = kwargs.get('Low Power HPWH', False) | |||
There was a problem hiding this comment.
I think it'd be better to move these parameters into the hpxml.py file. I can
start to work on that.
There was a problem hiding this comment.
Agreed, when we have HPXML support for 120V HPWHs, we'll get rid of this and a few other things that are just for testing purposes.
This reverts commit f099d2a. We need the tempering valve for the time being. We can more formally integrate this later, but since in our test cases WH setpoint is 140F with a tempering valve set to 125 F this is necessary for the current runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a 120V HPWH into OCHRE, based on the model in OS-HPMXL. This model is based on the Rheem, shared circuit product. I can potentially also add the dedicated circuit version (higher power, but requires an open available 15A circuit). We can also allow backup elements like AO Smith includes.
This also includes adding the ability to model a tempering valve. These products have an integrated tempering valve, so you can overheat the tank to increase the stored energy to compensate for the lower heating rate.
Not all of this is supported in HPXML yet, but that's coming soon. I want to wait to merge this in until those changes happen so that we can properly support this going forward, rather than just having something triggered by temporary flags.
Fixes #133