Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

148-ducts-in-multiple-locations #151

Merged
merged 3 commits into from
Dec 3, 2024
Merged

148-ducts-in-multiple-locations #151

merged 3 commits into from
Dec 3, 2024

Conversation

mnblonsky
Copy link
Collaborator

@mnblonsky mnblonsky commented Nov 12, 2024 •
edited
Loading

Addresses #148

  • Reference the issue your PR is fixing
  • Assign at least 1 reviewer for your PR
  • Test with run_dwelling.py or other script
  • Update documentation as appropriate
  • Update changelog as appropriate

@mnblonsky mnblonsky self-assigned this Nov 12, 2024
@mnblonsky mnblonsky requested a review from jmaguire1 November 12, 2024 23:58
@mnblonsky mnblonsky marked this pull request as ready for review November 13, 2024 00:17
jmaguire1
jmaguire1 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@jmaguire1 jmaguire1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with the past Schneider runs. There were still some other issues (hot tub pump not being recognized being the most common), but this definitely fixes the duct issues.

@jmaguire1 jmaguire1 merged commit bd73b3f into dev Dec 3, 2024
@jmaguire1 jmaguire1 deleted the 148-ducts-in-multiple-locations branch December 6, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaguire1 jmaguire1 jmaguire1 approved these changes

Assignees

@mnblonsky mnblonsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnblonsky @jmaguire1