Replace Hard-Coded Sensible Capacity Curves with ADP/BF #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. rated conditions
…to match add_heating_system function variable input order convention
… screwing things up when running OS CLI
…o adp_bf_method_design_shr
…ties to calculate design SHR. Cool Cap Design throwing undefined variable error in Psychrometrics.CalculateSHR
…sn't numerically fail. hvac_cooling_ap.rated_shr and hvac_cooling_shr showing 0.05 discrepancy. ask team if this is a problem?
…etter approach to calculating the design SHR and design airflow through the cooling coil for the following OS-HPXML equipment types: Central AC, A2A HP used for cooling, Mini-Split AC, and ducted MSHP used for cooling
Sashadf1
changed the title
…o adp_bf_method_design_shr # Conflicts: # HPXMLtoOpenStudio/measure.rb # HPXMLtoOpenStudio/resources/hvac.rb # HPXMLtoOpenStudio/resources/hvac_sizing.rb # HPXMLtoOpenStudio/resources/psychrometrics.rb
…o adp_bf_method_design_shr # Conflicts: # HPXMLtoOpenStudio/measure.xml
jonwinkler
reviewed
Aug 21, 2024
jonwinkler
reviewed
Aug 21, 2024
…o adp_bf_method_design_shr # Conflicts: # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hvac_sizing.rb # workflow/tests/base_results/results_acca_hvac.csv # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv # workflow/tests/base_results/results_sizing.csv
… cooling equipment
jonwinkler
reviewed
Aug 27, 2024
… in apply_hvac_equipment_adjustments; cosmetic change only
…ure.xml gets overwritten by CI anyway
|
@shorowit to resolve merge conflicts and coordinate w/ residential team to test w/ diverse buildstock run |
…o adp_bf_method_design_shr # Conflicts: # HPXMLtoOpenStudio/measure.rb # HPXMLtoOpenStudio/measure.xml
6 tasks
…o adp_bf_method_design_shr # Conflicts: # HPXMLtoOpenStudio/measure.xml
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[improves the design airflow/design SHR calculation in apply_hvac_equipment_adjustments within hvac_sizing.rb for central-ducted air systems used for cooling]
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
Schematron validator (EPvalidator.xml) has been updatedSample files have been added/updated (openstudio tasks.rb update_hpxmls)Tests have been added/updated (HPXMLtoOpenStudio/tests/test_hvac_sizing.rband/orworkflow/tests/test*.rb)Changelog has been updatedopenstudio tasks.rb update_measureshas been runmerge and test w/ diverse set of buildings/climates in ResStockhouse 237.xml (Florida) edge case was investigated, and the ADP/BF approach for this case produces more reasonable equipment capacities (see attached excel, ppt).ADP_BF_ResStock Testing Results.pptx
testing_ResStock_datapoint_237.xlsx