Update HVAC models per RESNET HVAC addendum #1879

yzhou601 · 2024-11-09T05:22:55Z

Pull Request Description

closes #1871

Checklist

Not all may apply:

Schematron validator (EPvalidator.xml) has been updated
Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
Documentation has been updated
Changelog has been updated
openstudio tasks.rb update_measures has been run
No unexpected changes to simulation results of sample files

…o resnet_heat_pump

…same resnet updates, remove in.schedules.csv in test_hvac.rb

…, etc.

…-HPXML into resnet_heat_pump

…o resnet_heat_pump

HPXMLtoOpenStudio/resources/defaults.rb

HPXMLtoOpenStudio/resources/hvac.rb

…o resnet_heat_pump

…-HPXML into resnet_heat_pump

…o resnet_heat_pump

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml

…-HPXML into resnet_heat_pump

…pumps and mini-splits.

…-HPXML into resnet_heat_pump

yzhou601 · 2025-02-12T01:22:29Z

CI is complaining about the BuildResidentialHPXML test: test_workflows at the extra-second-heating-system-fireplace-to-heat-pump.xml. I checked the error and generated hpxml file, it's because the HeatingCapacity17F input is not consistent with 17F nominal datapoint in detailed performance data. But I can't find the place where the HeatingCapacity17F is set. @joseph-robertson @shorowit can you help point out the place?

HPXMLtoOpenStudio/tests/test_defaults.rb

shorowit · 2025-02-12T15:15:29Z

CI is complaining about the BuildResidentialHPXML test: test_workflows at the extra-second-heating-system-fireplace-to-heat-pump.xml. I checked the error and generated hpxml file, it's because the HeatingCapacity17F input is not consistent with 17F nominal datapoint in detailed performance data. But I can't find the place where the HeatingCapacity17F is set. @joseph-robertson @shorowit can you help point out the place?

Just fixed it. HeatingCapacity17F was being defaulted, but it had more decimal places than the detailed performance data defaulted capacities.

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml

…-HPXML into resnet_heat_pump

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml

docs/source/workflow_inputs.rst

…o resnet_heat_pump # Conflicts: # Changelog.md # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv

…-HPXML into resnet_heat_pump

yzhou601 added 2 commits November 8, 2024 22:20

updated fan watts per cfm default, added fan model type

7e5af49

update measures

bee0df1

yzhou601 self-assigned this Nov 12, 2024

shorowit mentioned this pull request Nov 12, 2024

Update HP models per RESNET HVAC addendum #1871

Open

22 tasks

yzhou601 and others added 10 commits November 13, 2024 12:54

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

54e3ad7

…o resnet_heat_pump

fix tests, changed defrost fan power cubic calculation to follow the …

a7d4806

…same resnet updates, remove in.schedules.csv in test_hvac.rb

one more fix

b40b1e6

Latest results.

06c27af

revert measured w/cfm defaults, updated rated fan power default, docs…

2d1fb0c

…, etc.

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

22af55b

…-HPXML into resnet_heat_pump

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

554f49a

…o resnet_heat_pump

update_measures

bf5d323

temporarily reverted indoor sensibility change

ac9c0e1

Latest results.

c2c484d

yzhou601 commented Nov 15, 2024

View reviewed changes

yzhou601 and others added 10 commits November 25, 2024 13:34

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

f05a5bf

…o resnet_heat_pump

update measures

a322dc4

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

9c9d5be

…-HPXML into resnet_heat_pump

Latest results.

3cae1a8

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

f2f9135

…o resnet_heat_pump

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

1edbedd

…o resnet_heat_pump

Updated indoor sensitivity coefficients

7a5f48a

added temperature bounds for indoor sensitivity

abb9663

Latest results.

01c5315

Latest results.

c495f89

shorowit reviewed Dec 13, 2024

View reviewed changes

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml Outdated Show resolved Hide resolved

yzhou601 and others added 4 commits December 13, 2024 12:01

renamed fanmotortype, and started variable speed assumption update

f1e8a75

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

7ffcbff

…-HPXML into resnet_heat_pump

one more rename

ab5d5eb

Allows optional EER or EER2 inputs for central air conditioners/heat …

f0fe87e

…pumps and mini-splits.

GitHub Action and others added 4 commits February 12, 2025 00:17

Latest results.

2eed57d

add unit test for default variable speed detailed performance data

b52c0ca

fix some ci errors

5553bdd

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

18b9995

…-HPXML into resnet_heat_pump

yzhou601 commented Feb 12, 2025

View reviewed changes

HPXMLtoOpenStudio/tests/test_defaults.rb Show resolved Hide resolved

Fix CI failure.

c47adc8

shorowit and others added 2 commits February 12, 2025 08:17

Fix measure; not sure what happened before.

c388087

More fix on the BuildResidential test

849bebf

shorowit reviewed Feb 12, 2025

View reviewed changes

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml Outdated Show resolved Hide resolved

shorowit and others added 7 commits February 12, 2025 09:45

Use capacity rounding consistent with what hvac_sizing.rb does

e00c9e9

Latest results.

2c65c7d

Latest results.

c0328e4

Update expected values.

f5e09fe

improve epvalidator for capacity consistency

4ccf04c

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

6067959

…-HPXML into resnet_heat_pump

update measures

6b268d3

yzhou601 commented Feb 12, 2025

View reviewed changes

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml Outdated Show resolved Hide resolved

shorowit reviewed Feb 12, 2025

View reviewed changes

docs/source/workflow_inputs.rst Show resolved Hide resolved

yzhou601 and others added 9 commits February 13, 2025 11:21

EPvalidator.xml improvements

4b1ce41

relax requirements for nominal speed data points

e985386

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

820442e

…-HPXML into resnet_heat_pump

oops

c86c1f5

fix test file fraction of nominal

c1b85ec

Latest results.

09de5d8

fix unit tests with nominal datapoints being optional

6aac7c1

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

6244315

…-HPXML into resnet_heat_pump

shorowit mentioned this pull request Feb 15, 2025

HeatingCapacityFraction17F #1931

Draft

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update HVAC models per RESNET HVAC addendum #1879

Update HVAC models per RESNET HVAC addendum #1879

yzhou601 commented Nov 9, 2024

yzhou601 commented Feb 12, 2025

shorowit commented Feb 12, 2025

Update HVAC models per RESNET HVAC addendum #1879

Are you sure you want to change the base?

Update HVAC models per RESNET HVAC addendum #1879

Conversation

yzhou601 commented Nov 9, 2024

Pull Request Description

Checklist

yzhou601 commented Feb 12, 2025

shorowit commented Feb 12, 2025