Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow .sch extensions for schematron documents #5248

Closed
shorowit opened this issue Aug 30, 2024 · 1 comment · Fixed by #5333
Closed

Allow .sch extensions for schematron documents #5248

shorowit opened this issue Aug 30, 2024 · 1 comment · Fixed by #5333
Labels
Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed

Comments

@shorowit
Copy link
Contributor

Enhancement Request

Apparently schematron documents are supposed to have a .sch file extension. And that's what e.g. BuildingSync uses. However, OpenStudio throws an error when validating that only .xml is allowed.

RuntimeError: /srv/jenkins/openstudio/docker-volumes/ubuntu-2204-nightly/Openstudio/src/utilities/xml/XMLValidator.cpp@188 : Schema path extension '.sch' not supported.

If it's a pain to support both, I don't have a problem renaming our Schematron docs to .sch.
@shorowit shorowit added Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Aug 30, 2024
@shorowit shorowit mentioned this issue Sep 3, 2024
Open
5 tasks
@jmarrec
Copy link
Collaborator

jmarrec commented Dec 19, 2024

For <insert reason>, it's checking if it's .xml or .sct, not .sch.

I'm not sure what I got that .sct from?

Should I replace .sct with .sch? I don't think .sct is a think

@jmarrec jmarrec mentioned this issue Dec 19, 2024
Merged
8 tasks
jmarrec added a commit that referenced this issue Dec 23, 2024
@jmarrec
Merge pull request #5333 from NREL/5248-SchematronExtension
0314c3e 
Fix #5248 - Typo in Schematron extension: .sch, not .sct!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5248 - Typo in Schematron extension: .sch, not .sct! NREL/OpenStudio
2 participants
@jmarrec @shorowit