Using CoilHeatingWaters in the Supplemental Heating Coil Object Type field for the AirLoopHVACUnitaryHeatPumpAirToAir group causes failure.

[hobsonbw]

Issue overview

When using OpenStudio::Model::AirLoopHVACUnitaryHeatPumpAirToAir.new(), specifying a supplementary heating coil of type CoilHeatingWater fails. This occurs even though the plant loop, branches, and connector objects to support the hot water supplemental heating coil are placed on the demand side of the plantloop.

Current Behavior

The following error in Windows:
[BOOST_ASSERT] <2> Assertion result failed on line 244 of class openstudio::model::HVACComponent __cdecl openstudio::model::detail::AirLoopHVACUnitaryHeatPumpAirToAir_Impl::supplementalHeatingCoil(void) const in file D:\OSN\Openstudio\src\model\AirLoopHVACUnitaryHeatPumpAirToAir.cpp.

And the following more severe error with a segmentation fault in the Linux-based development environment:
[BOOST_ASSERT] <2> Assertion result failed on line 244 of openstudio::model::HVACComponent openstudio::model::detail::AirLoopHVACUnitaryHeatPumpAirToAir_Impl::supplementalHeatingCoil() const in file /srv/jenkins/openstudio/git/nightly/ubuntu_2004/src/model/AirLoopHVACUnitaryHeatPumpAirToAir.cpp. hp_test_lnx.rb:53: [BUG] Segmentation fault at 0x0000000000000000 ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-linux]

The above segmentation fault is followed by several hundred lines of error code under headings 'Control frame information', 'Ruby level backtrace information', 'Machine register context', and 'Other runtime information'.

Expected Behavior

The AirLoopHVACUnitaryHeatPumpAirToAir should accept a CoilHeatingWater for the supplemental heating coil, at least according to the EnergyPlus 24.2.0 documentation.

Steps to Reproduce

Try to specify a hot water supplemental heating coil in the AirLoopHVACUnitaryHeatPumpAirToAir group. Example files here.

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

• Platform (Operating system, version): Windows 10 Enterprise, 10.0.19045 Build 19045
• Version of OpenStudio (if using an intermediate build, include SHA): 3.7.0, 3.9.0
• Platform (Operating system, version): Ubuntu, 20.04.6 LTS
• Version of OpenStudio (if using an intermediate build, include SHA): 3.7.0, 3.9.0

Context

[jmarrec]

Two issues:

• We don't accept two supplemental heating coil types we should per E+
• When the Ctor fails to assign, it tries to remove() before LOG_AND_THROW, and that, unfortutenaly fails with the assert

E+ idd:

   A12, \field Supplemental Heating Coil Object Type
        \required-field
        \type choice
        \key Coil:Heating:Fuel
        \key Coil:Heating:Electric
        \key Coil:Heating:Water
        \key Coil:Heating:Steam
        \note works with gas, electric, hot water and steam heating coils

it is NOT ok here:

OpenStudio/src/model/AirLoopHVACUnitaryHeatPumpAirToAir.cpp

Lines 735 to 740 in 5bc916e

	ok = setSupplementalHeatingCoil(supplementalHeatingCoil);
	if (!ok) {
	remove();
	LOG_AND_THROW("Unable to set " << briefDescription() << "'s supplemental heating coil to " << supplementalHeatingCoil.briefDescription()
	<< ".");
	}

so in children, it throws

OpenStudio/src/model/AirLoopHVACUnitaryHeatPumpAirToAir.cpp

Line 120 in 5bc916e

result.push_back(supplementalHeatingCoil());

[jmarrec]

Oh awesome, the other one, AirLoopHVACUnitaryHeatPumpAirToAirMultiSpeed does not have any tests.
The addToNode is unrestricted, and the clone() method fails to reset the inlet/outlet nodes.