Update IDD fields for water equipment to have \ip-units gal/min

[macumber]

Issue overview

Originally reported at openstudiocoalition/OpenStudioApplication#779

Water equipment with flow rates in \units m3/s should have \ip-units gal/min to override the default conversion to ft3/s which is not used in practice.

Current Behavior

Water equipment with flow rates in \units m3/s is converted to ft3/s when converting to IP units.

Expected Behavior

Water equipment with flow rates in \units m3/s should be converted to gal/min when converting to IP units.

Steps to Reproduce

OpenStudio::IdfObject.new("OS:SolarCollector:FlatPlate:Water".to_IddObjectType).iddObject.getField(6).get.properties.units.get
OpenStudio::IdfObject.new("OS:SolarCollector:FlatPlate:Water".to_IddObjectType).iddObject.getField(6).get.properties.ipUnits.get

Possible Solution

Add \ip-units gal/min to the OpenStudio.idd for fields with water flow rates. OS:SolarCollector:FlatPlate:Water::Maximum Flow Rate is one field but a complete review would be a good idea.

Details

Environment

Some additional details about your environment for this issue (if relevant):

• Platform (Operating system, version):
• Version of OpenStudio (if using an intermediate build, include SHA):

Context

[macumber]

This script https://github.com/NREL/OpenStudio/blob/develop/developer/ruby/FindAndAddMissingIPUnits.rb appears to have tried to address this issue