Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V23.2.0-IOFreeze - wrap DistrictHeating:Steam and rename DistrictHeating to DistrictHeatingWater #4972

Merged
merged 31 commits into from
Sep 20, 2023
Merged

V23.2.0-IOFreeze - wrap DistrictHeating:Steam and rename DistrictHeating to DistrictHeatingWater #4972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
467b13b
Update idd for water fraction schedule and new district heating steam.
joseph-robertson Aug 30, 2023
857c073
Updates for district heating water capacity fraction schedule.
joseph-robertson Aug 30, 2023
1f48f28
Add source files for district heating steam.
joseph-robertson Aug 30, 2023
bb5c0c1
Add ft files for district heating steam.
joseph-robertson Aug 30, 2023
bb9ef23
Formatting.
joseph-robertson Aug 30, 2023
04eb9c0
Source ft file updates for district heating steam.
joseph-robertson Aug 30, 2023
78c53dd
Few more updates in hpp files.
joseph-robertson Aug 30, 2023
94c6c24
Update all district types for capacity fraction schedule.
joseph-robertson Aug 30, 2023
2f20fb8
Fix includes for district cooling.
joseph-robertson Aug 30, 2023
90986ea
Few updates around steam vs district heating steam.
joseph-robertson Aug 30, 2023
35666bd
Minor typo in new district model tests.
joseph-robertson Aug 30, 2023
74b1049
Update schedule type registry.
joseph-robertson Sep 12, 2023
42296ae
Update ft for all district objects.
joseph-robertson Sep 12, 2023
709a375
Add nominal capacity in model tests.
joseph-robertson Sep 12, 2023
059f4d0
Create new ft tests for all district objects.
joseph-robertson Sep 12, 2023
431293d
Few model test typos and formatting issues.
joseph-robertson Sep 12, 2023
4c3f3bf
Rename Class And IDD object: DistrictHeating to DistrictHeating:Water
jmarrec Sep 18, 2023
7a3a5ab
Merge remote-tracking branch 'origin/district-heating-steam' into v23…
jmarrec Sep 18, 2023
56c9b31
Add missing DistrictCooling::getScheduleTypeKeys + typo in merge conf…
jmarrec Sep 18, 2023
dd24df3
Fix typos
jmarrec Sep 19, 2023
a44bf14
Clean up FTs
jmarrec Sep 19, 2023
6fb2a7e
Add OS_DistrictHeating_Steam to PlantEqScheme + SizingPlant enum checks
jmarrec Sep 19, 2023
8ef1ec1
SWIG: helper macro for deprecated class with alias + python docstring
jmarrec Sep 19, 2023
5db5abc
Add deprecation to release notes + update deprecated_methods.csv
jmarrec Sep 19, 2023
64a68dd
AllFuelTypes/in.idf: Simply load idf and save back
jmarrec Sep 19, 2023
6a402c4
Re-regenerate AllFuelTypes/in.idf
jmarrec Sep 19, 2023
2152e88
Skip a portion of SqlFileFixture.FuelTypes that fails because of E+
jmarrec Sep 19, 2023
e03655f
Make Capacity Fraction Schedule required-field (alwaysOnContinuousSch…
jmarrec Sep 20, 2023
426ab13
VT test for Making Capacity Fraction Schedule non optional
jmarrec Sep 20, 2023
3747954
VT for Making Capacity Fraction Schedule non optional
jmarrec Sep 20, 2023
57fea8f
Merge remote-tracking branch 'origin/v23.2.0-IOFreeze' into v23.2.0-I…
jmarrec Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions developer/doc/ReleaseNotes/OpenStudio_Release_Notes_3_7_0_TDB.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ You can also refer to the [OpenStudio SDK Python Binding Version Compatibility M
* Fix #4930 - Support undisturbed ground temperature models on GroundHeatExchangerVertical
* Update `GroundHeatExchanger:Vertical` to actually use the Ground Temeprature Model field
* [#4923](https://github.com/NREL/OpenStudio/pull/4923) - Fix #4692 - Modify `Model::load` to use the VersionTranslator instead of loading it assuming the version of the loaded OSM is the same as the current SDK version being used.
* [#4972](https://github.com/NREL/OpenStudio/pull/4972) - V23.2.0-IOFreeze - wrap `DistrictHeating:Steam` and rename `DistrictHeating` to `DistrictHeatingWater`
* The `DistrictHeating` class (and related Model getters such as `Model::getDistrictHeatings`) are deprecated but kept for backward Compatibility for now.
Comment on lines +85 to +86
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to release notes


## Minor changes and bug fixes

Expand Down
51 changes: 50 additions & 1 deletion developer/ruby/deprecated_methods.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,4 +236,53 @@ model,SurfacePropertyExposedFoundationPerimeter,surfaceName,3.7.0,19bea0ce243d4f
model,TableMultiVariableLookup,Entire Class,3.5.0,1c7521a7912473b3b8ba5c533fdf810936ff5c60,TableLookup,
energyplus,ForwardTranslator,translateTableMultiVariableLookup,3.5.0,1c7521a7912473b3b8ba5c533fdf810936ff5c60,Remove TableMultiVariableLookup for TableLookup,
energyplus,ForwardTranslatePlantEquipmentOperationSchemes,componentType,3.6.0,1417dcb7f48c92629a1e5c43dd2b030c1711bf99,Model SDK: HVACComponent::componentType(),
energyplus,ForwardTranslatePlantEquipmentOperationSchemes,plantLoopType,3.6.0,1417dcb7f48c92629a1e5c43dd2b030c1711bf99,Model SDK: Loop::componentType(),
energyplus,ForwardTranslatePlantEquipmentOperationSchemes,plantLoopType,3.6.0,1417dcb7f48c92629a1e5c43dd2b030c1711bf99,Model SDK: Loop::componentType(),
model,DistrictHeating,Entire Class,3.7.0,4c3f3bf17b9da6bf9ff4bafd5cbb954a08333045,Renamed to DistrictHeatingWater,
model,AirLoopHVACUnitarySystem,maximumCyclingRate,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,coolingCoil()->maximumCyclingRate,
model,AirLoopHVACUnitarySystem,isMaximumCyclingRateDefaulted,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Child coolingCoil holds the property but it's required,
model,AirLoopHVACUnitarySystem,setMaximumCyclingRate,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,coolingCoil()->setMaximumCyclingRate,
model,AirLoopHVACUnitarySystem,resetMaximumCyclingRate,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Child coolingCoil holds the property but it's required,
model,AirLoopHVACUnitarySystem,heatPumpTimeConstant,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,coolingCoil()->latentCapacityTimeConstant,
model,AirLoopHVACUnitarySystem,isHeatPumpTimeConstantDefaulted,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Child coolingCoil holds the property but it's required,
model,AirLoopHVACUnitarySystem,setHeatPumpTimeConstant,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,coolingCoil()->setLatentCapacityTimeConstant,
model,AirLoopHVACUnitarySystem,resetHeatPumpTimeConstant,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Child coolingCoil holds the property but it's required,
model,AirLoopHVACUnitarySystem,heatPumpFanDelayTime,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,coolingCoil()->fanDelayTime,
model,AirLoopHVACUnitarySystem,isHeatPumpFanDelayTimeDefaulted,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Child coolingCoil holds the property but it's required,
model,AirLoopHVACUnitarySystem,setHeatPumpFanDelayTime,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,coolingCoil()->setFanDelayTime,
model,AirLoopHVACUnitarySystem,resetHeatPumpFanDelayTime,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Child coolingCoil holds the property but it's required,
model,AirLoopHVACUnitarySystem,fractionofOnCyclePowerUse,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Property no longer used,
model,AirLoopHVACUnitarySystem,isFractionofOnCyclePowerUseDefaulted,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Property no longer used,
model,AirLoopHVACUnitarySystem,setFractionofOnCyclePowerUse,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Property no longer used,
model,AirLoopHVACUnitarySystem,resetFractionofOnCyclePowerUse,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Property no longer used,
model,ZoneHVACWaterToAirHeatPump,maximumCyclingRate,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,coolingCoil()->maximumCyclingRate,
model,ZoneHVACWaterToAirHeatPump,isMaximumCyclingRateDefaulted,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Child coolingCoil holds the property but it's required,
model,ZoneHVACWaterToAirHeatPump,setMaximumCyclingRate,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,coolingCoil()->setMaximumCyclingRate,
model,ZoneHVACWaterToAirHeatPump,resetMaximumCyclingRate,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Child coolingCoil holds the property but it's required,
model,ZoneHVACWaterToAirHeatPump,heatPumpTimeConstant,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,coolingCoil()->latentCapacityTimeConstant,
model,ZoneHVACWaterToAirHeatPump,isHeatPumpTimeConstantDefaulted,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Child coolingCoil holds the property but it's required,
model,ZoneHVACWaterToAirHeatPump,setHeatPumpTimeConstant,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,coolingCoil()->setLatentCapacityTimeConstant,
model,ZoneHVACWaterToAirHeatPump,resetHeatPumpTimeConstant,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Child coolingCoil holds the property but it's required,
model,ZoneHVACWaterToAirHeatPump,heatPumpFanDelayTime,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,coolingCoil()->fanDelayTime,
model,ZoneHVACWaterToAirHeatPump,isHeatPumpFanDelayTimeDefaulted,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Child coolingCoil holds the property but it's required,
model,ZoneHVACWaterToAirHeatPump,setHeatPumpFanDelayTime,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,coolingCoil()->setFanDelayTime,
model,ZoneHVACWaterToAirHeatPump,resetHeatPumpFanDelayTime,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Child coolingCoil holds the property but it's required,
model,ZoneHVACWaterToAirHeatPump,fractionofOnCyclePowerUse,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Property no longer used,
model,ZoneHVACWaterToAirHeatPump,isFractionofOnCyclePowerUseDefaulted,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Property no longer used,
model,ZoneHVACWaterToAirHeatPump,setFractionofOnCyclePowerUse,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Property no longer used,
model,ZoneHVACWaterToAirHeatPump,resetFractionofOnCyclePowerUse,3.7.0,d0e00eff0cbb5420f5447ff9c94e3afc11785482,None: Property no longer used,
model,EnvironmentalImpactFactors,districtHeatingEfficiency,3.7.0,49433c8c8108785d5ed6d11bd8e48b8d5a5be843,districtHeatingWaterEfficiency,
model,EnvironmentalImpactFactors,steamConversionEfficiency,3.7.0,49433c8c8108785d5ed6d11bd8e48b8d5a5be843,districtHeatingSteamConversionEfficiency,
model,EnvironmentalImpactFactors,setDistrictHeatingEfficiency,3.7.0,49433c8c8108785d5ed6d11bd8e48b8d5a5be843,setDistrictHeatingWaterEfficiency,
model,EnvironmentalImpactFactors,setSteamConversionEfficiency,3.7.0,49433c8c8108785d5ed6d11bd8e48b8d5a5be843,setDistrictHeatingSteamConversionEfficiency,
model,AirLoopHVACUnitarySystem,setSupplyAirFlowRateMethodDuringCoolingOperation,3.7.0,84bd57c5117cba9fc0716f2329d70ba5708c080a,"Done when calling setSupplyAirFlowRateDuringCoolingOperation, autosizeSupplyAirFlowRateDuringCoolingOperation, setSupplyAirFlowRatePerFloorAreaDuringCoolingOperation, setFractionofAutosizedDesignCoolingSupplyAirFlowRate, setDesignSupplyAirFlowRatePerUnitofCapacityDuringCoolingOperation",
model,AirLoopHVACUnitarySystem,resetSupplyAirFlowRateMethodDuringCoolingOperation,3.7.0,84bd57c5117cba9fc0716f2329d70ba5708c080a,"Done when calling setSupplyAirFlowRateDuringCoolingOperation, autosizeSupplyAirFlowRateDuringCoolingOperation, setSupplyAirFlowRatePerFloorAreaDuringCoolingOperation, setFractionofAutosizedDesignCoolingSupplyAirFlowRate, setDesignSupplyAirFlowRatePerUnitofCapacityDuringCoolingOperation",
model,AirLoopHVACUnitarySystem,resetSupplyAirFlowRateDuringCoolingOperation,3.7.0,84bd57c5117cba9fc0716f2329d70ba5708c080a,"Done when calling setSupplyAirFlowRateDuringCoolingOperation, autosizeSupplyAirFlowRateDuringCoolingOperation, setSupplyAirFlowRatePerFloorAreaDuringCoolingOperation, setFractionofAutosizedDesignCoolingSupplyAirFlowRate, setDesignSupplyAirFlowRatePerUnitofCapacityDuringCoolingOperation",
model,AirLoopHVACUnitarySystem,resetSupplyAirFlowRatePerFloorAreaDuringCoolingOperation,3.7.0,84bd57c5117cba9fc0716f2329d70ba5708c080a,"Done when calling setSupplyAirFlowRateDuringCoolingOperation, autosizeSupplyAirFlowRateDuringCoolingOperation, setSupplyAirFlowRatePerFloorAreaDuringCoolingOperation, setFractionofAutosizedDesignCoolingSupplyAirFlowRate, setDesignSupplyAirFlowRatePerUnitofCapacityDuringCoolingOperation",
model,AirLoopHVACUnitarySystem,resetFractionofAutosizedDesignCoolingSupplyAirFlowRate,3.7.0,84bd57c5117cba9fc0716f2329d70ba5708c080a,"Done when calling setSupplyAirFlowRateDuringCoolingOperation, autosizeSupplyAirFlowRateDuringCoolingOperation, setSupplyAirFlowRatePerFloorAreaDuringCoolingOperation, setFractionofAutosizedDesignCoolingSupplyAirFlowRate, setDesignSupplyAirFlowRatePerUnitofCapacityDuringCoolingOperation",
model,AirLoopHVACUnitarySystem,resetDesignSupplyAirFlowRatePerUnitofCapacityDuringCoolingOperation,3.7.0,84bd57c5117cba9fc0716f2329d70ba5708c080a,"Done when calling setSupplyAirFlowRateDuringCoolingOperation, autosizeSupplyAirFlowRateDuringCoolingOperation, setSupplyAirFlowRatePerFloorAreaDuringCoolingOperation, setFractionofAutosizedDesignCoolingSupplyAirFlowRate, setDesignSupplyAirFlowRatePerUnitofCapacityDuringCoolingOperation",
model,AirLoopHVACUnitarySystem,setSupplyAirFlowRateMethodDuringHeatingOperation,3.7.0,84bd57c5117cba9fc0716f2329d70ba5708c080a,"Done when calling setSupplyAirFlowRateDuringHeatingOperation, autosizeSupplyAirFlowRateDuringHeatingOperation, setSupplyAirFlowRatePerFloorAreaDuringHeatingOperation, setFractionofAutosizedDesignHeatingSupplyAirFlowRate, setDesignSupplyAirFlowRatePerUnitofCapacityDuringHeatingOperation",
model,AirLoopHVACUnitarySystem,resetSupplyAirFlowRateMethodDuringHeatingOperation,3.7.0,84bd57c5117cba9fc0716f2329d70ba5708c080a,"Done when calling setSupplyAirFlowRateDuringHeatingOperation, autosizeSupplyAirFlowRateDuringHeatingOperation, setSupplyAirFlowRatePerFloorAreaDuringHeatingOperation, setFractionofAutosizedDesignHeatingSupplyAirFlowRate, setDesignSupplyAirFlowRatePerUnitofCapacityDuringHeatingOperation",
model,AirLoopHVACUnitarySystem,resetSupplyAirFlowRateDuringHeatingOperation,3.7.0,84bd57c5117cba9fc0716f2329d70ba5708c080a,"Done when calling setSupplyAirFlowRateDuringHeatingOperation, autosizeSupplyAirFlowRateDuringHeatingOperation, setSupplyAirFlowRatePerFloorAreaDuringHeatingOperation, setFractionofAutosizedDesignHeatingSupplyAirFlowRate, setDesignSupplyAirFlowRatePerUnitofCapacityDuringHeatingOperation",
model,AirLoopHVACUnitarySystem,resetSupplyAirFlowRatePerFloorAreaduringHeatingOperation,3.7.0,84bd57c5117cba9fc0716f2329d70ba5708c080a,"Done when calling setSupplyAirFlowRateDuringHeatingOperation, autosizeSupplyAirFlowRateDuringHeatingOperation, setSupplyAirFlowRatePerFloorAreaDuringHeatingOperation, setFractionofAutosizedDesignHeatingSupplyAirFlowRate, setDesignSupplyAirFlowRatePerUnitofCapacityDuringHeatingOperation",
model,AirLoopHVACUnitarySystem,resetFractionofAutosizedDesignHeatingSupplyAirFlowRate,3.7.0,84bd57c5117cba9fc0716f2329d70ba5708c080a,"Done when calling setSupplyAirFlowRateDuringHeatingOperation, autosizeSupplyAirFlowRateDuringHeatingOperation, setSupplyAirFlowRatePerFloorAreaDuringHeatingOperation, setFractionofAutosizedDesignHeatingSupplyAirFlowRate, setDesignSupplyAirFlowRatePerUnitofCapacityDuringHeatingOperation",
model,AirLoopHVACUnitarySystem,resetDesignSupplyAirFlowRatePerUnitofCapacityDuringHeatingOperation,3.7.0,84bd57c5117cba9fc0716f2329d70ba5708c080a,"Done when calling setSupplyAirFlowRateDuringHeatingOperation, autosizeSupplyAirFlowRateDuringHeatingOperation, setSupplyAirFlowRatePerFloorAreaDuringHeatingOperation, setFractionofAutosizedDesignHeatingSupplyAirFlowRate, setDesignSupplyAirFlowRatePerUnitofCapacityDuringHeatingOperation",
Loading