Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap ZoneHVAC:EvaporativeCoolerUnit #5326

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
+1,632 −13
Draft

Wrap ZoneHVAC:EvaporativeCoolerUnit #5326

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
995c10a
Add ZoneHVAC:EvaporativeCoolerUnit to idd.
joseph-robertson Dec 18, 2024
b06d24a
Update the new idd entry.
joseph-robertson Dec 19, 2024
835b1ef
Merge branch 'develop' into zonehvac-evap-cooler
joseph-robertson Dec 19, 2024
861dfdf
First add of model, ft, and test files.
joseph-robertson Dec 20, 2024
44f0405
Update model resource files.
joseph-robertson Dec 20, 2024
42303c1
Update nodes in ft, general cleanup.
joseph-robertson Dec 23, 2024
9265da3
Fix and improve model and ft tests.
joseph-robertson Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 88 additions & 1 deletion resources/model/OpenStudio.idd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24496,6 +24496,7 @@ OS:EvaporativeCooler:Indirect:ResearchSpecial,
\type alpha
\required-field
\reference ConnectionObject
\reference EvapCoolerNames
A3 , \field Availability Schedule Name
\note Availability schedule name for this system. Schedule value > 0 means the system is available.
\note If this field is blank, the system is always available.
Expand Down Expand Up @@ -24646,6 +24647,7 @@ OS:EvaporativeCooler:Direct:ResearchSpecial,
\type alpha
\required-field
\reference ConnectionObject
\reference EvapCoolerNames
A3, \field Availability Schedule Name
\type object-list
\required-field
Expand Down Expand Up @@ -31181,13 +31183,98 @@ OS:ZoneHVAC:CoolingPanel:RadiantConvective:Water,
\minimum 0
\maximum 1

OS:ZoneHVAC:EvaporativeCoolerUnit,
\memo Zone evaporative cooler. Forced-convection cooling-only unit with supply fan,
\memo 100% outdoor air supply. Optional relief exhaust node
\min-fields 16
A1, \field Handle
\type handle
\required-field
A2, \field Name
\required-field
\type alpha
\reference ConnectionObject
A3, \field Availability Schedule Name
\note Availability schedule name for this system. Schedule value > 0 means the system is available.
\note If this field is blank, the system is always available.
\type object-list
\object-list ScheduleNames
joseph-robertson marked this conversation as resolved.
Show resolved Hide resolved
A4, \field Availability Manager List Name
\note Enter the name of an AvailabilityManagerAssignmentList object.
\type object-list
\object-list SystemAvailabilityManagerLists
A5, \field Outdoor Air Inlet Node Name
\required-field
\type object-list
\object-list ConnectionNames
\note this is an outdoor air node
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may want to not add it?

A6, \field Cooler Outlet Node Name
\required-field
\type object-list
\object-list ConnectionNames
\note this is a zone inlet node
A7, \field Zone Relief Air Node Name
\type object-list
\object-list ConnectionNames
\note this is a zone exhaust node, optional if flow is being balanced elsewhere
jmarrec marked this conversation as resolved.
Show resolved Hide resolved
A8, \field Supply Air Fan Name
\required-field
\type object-list
\object-list Fans
N1, \field Design Supply Air Flow Rate
\required-field
\units m3/s
\minimum> 0
\autosizable
A9, \field Fan Placement
\required-field
\type choice
\key BlowThrough
\key DrawThrough
A10, \field Cooler Unit Control Method
\required-field
\type choice
\key ZoneTemperatureDeadbandOnOffCycling
\key ZoneCoolingLoadOnOffCycling
\key ZoneCoolingLoadVariableSpeedFan
N2, \field Throttling Range Temperature Difference
\note used for ZoneTemperatureDeadbandOnOffCycling hysteresis range for thermostatic control
\type real
\units deltaC
\required-field
\minimum> 0.0
N3, \field Cooling Load Control Threshold Heat Transfer Rate
\type real
\units W
\required-field
\note Sign convention is that positive values indicate a cooling load
\minimum> 0.0
A11, \field First Evaporative Cooler Object Name
\required-field
\type object-list
\object-list EvapCoolerNames
A12, \field Second Evaporative Cooler Name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is just E+. still bothers me that the second doesn't have "Object" in it.
In any case, beware here because GenerateClass.rb will name the getters/setters differently and we don't want that.

I'd remove both "Object Name" from it, so that the getters are firstEvaporativeCooler and secondEvaporativeCooler

\note optional, used for direct/indirect configurations
\type object-list
\object-list EvapCoolerNames
A13, \field Design Specification ZoneHVAC Sizing Object Name
\note Enter the name of a DesignSpecificationZoneHVACSizing object.
\type object-list
\object-list DesignSpecificationZoneHVACSizingName
N4; \field Shut Off Relative Humidity
\note Zone relative humidity above which the evap cooler is shut off.
\type real
\minimum 0.00
\maximum 100.00
\units percent

joseph-robertson marked this conversation as resolved.
Show resolved Hide resolved
OS:ZoneMixing,
\memo ZoneMixing is a simple air exchange from one zone or space to another. Note that this statement
\memo only affects the energy balance of the "receiving" zone or space and will not produce
\memo any effect on the "source" zone. Mixing statements can be complementary and include
\memo multiple zones, but the balancing of flows between zones is left to the user's
\memo discretion.
\min-fields 18
\min-fields 18
A1, \field Handle
\type handle
\required-field
Expand Down
Loading