Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aidan py tests #117

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Aidan py tests #117

merged 4 commits into from
Sep 13, 2024

Conversation

AidanWesley
Copy link
Collaborator

Describe your changes

Added a test for the Xmin to the T98, I also removed the PVIGS dependency for the T98 test to now be reliant on the psm3_pytest.csv file.

Issue ticket number and link

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • [X ] I have performed a self-review of my code
  • [ X] Code changes are covered by tests.
  • [X ] Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • New functions added to init.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • What's new changelog has been updated in the docs

MDKempe and others added 3 commits June 14, 2024 14:57
added pytest for the Xmin and added it on the the test_T98. Removed the PPVGIS dependency.
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.51%. Comparing base (1df6afc) to head (57f92d6).
Report is 5 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #117      +/-   ##
===============================================
+ Coverage        66.03%   66.51%   +0.48%     
===============================================
  Files               36       36              
  Lines             3392     3396       +4     
===============================================
+ Hits              2240     2259      +19     
+ Misses            1152     1137      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-springer martin-springer merged commit cd52739 into development Sep 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants