Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geospatial AutoTemplating Integration #132

Merged
merged 7 commits into from
Dec 5, 2024

Conversation

tobin-ford
Copy link
Collaborator

Describe your changes

pvdeg.geospatial.analysis implements autotemplating. No need to specify a template for common pvdeg functions during analysis. Manually creating and providing templates is still an option. Docstrings updated with examples.

Issue ticket number and link

#131

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • Code changes have been evaluated for compatibility/integration with geospatial autotemplating (for future PRs)
  • New functions added to init.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • What's new changelog has been updated in the docs

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 35.18519% with 35 lines in your changes missing coverage. Please review.

Project coverage is 65.42%. Comparing base (2aa7332) to head (c1883fb).

Files with missing lines Patch % Lines
pvdeg/decorators.py 41.93% 18 Missing ⚠️
pvdeg/scenario.py 5.88% 16 Missing ⚠️
pvdeg/geospatial.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #132      +/-   ##
===============================================
- Coverage        65.65%   65.42%   -0.23%     
===============================================
  Files               36       36              
  Lines             3549     3575      +26     
===============================================
+ Hits              2330     2339       +9     
- Misses            1219     1236      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobin-ford tobin-ford changed the title Geospatial AutoTemplating Integratiohn Geospatial AutoTemplating Integration Nov 1, 2024
@martin-springer martin-springer merged commit 4b7ee6d into development Dec 5, 2024
6 checks passed
@martin-springer martin-springer deleted the dev_geospatial_templates_for_analysis branch December 5, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants