Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weather.py #67

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Update weather.py #67

merged 4 commits into from
Feb 15, 2024

Conversation

MDKempe
Copy link
Collaborator

@MDKempe MDKempe commented Feb 14, 2024

I had been using the meta information from "Source" to add meta information about the wind speed height but didn't realize that the meta information is not the same for all locations and this was causing crashing. I changed it to use the initial function call variable "database" to determine the source and the wind speed height.

Describe your changes

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • New functions added to init.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • What's new changelog has been updated in the docs

I had been using the meta information from "Source" to add meta information about the wind speed height but didn't realize that the meta information is not the same for all locations and this was causing crashing. I changed it to use the initial function call variable "database" to determine the source and the wind speed height.
@martin-springer martin-springer changed the base branch from main to development February 14, 2024 15:32
I found a stray print statement I used for error checking.
Fixed problems with the function call for standoff distance and added in a higher quality output. However, some of the unmodified code is malfunctioning.
@martin-springer martin-springer mentioned this pull request Feb 15, 2024
11 tasks
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (afe636e) 47.72% compared to head (fd1e903) 47.69%.

Files Patch % Lines
pvdeg/weather.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development      #67      +/-   ##
===============================================
- Coverage        47.72%   47.69%   -0.03%     
===============================================
  Files               28       28              
  Lines             1800     1801       +1     
===============================================
  Hits               859      859              
- Misses             941      942       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-springer martin-springer merged commit a17cd1d into development Feb 15, 2024
8 checks passed
@martin-springer martin-springer deleted the Kempe_Standoff branch February 15, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants