Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training&tools #83

Merged
merged 14 commits into from
May 3, 2024
Merged

Training&tools #83

merged 14 commits into from
May 3, 2024

Conversation

shirubana
Copy link
Member

@shirubana shirubana commented Apr 5, 2024

Describe your changes

Updated tutorials and tools

Type of change

Documentation renaming

Checklist before requesting a review

  • What's new changelog has been updated in the docs

@martin-springer martin-springer changed the base branch from main to development April 22, 2024 18:58
@martin-springer
Copy link
Collaborator

@shirubana - Do you mind taking a look at these conflicts? I believe you renamed 4 - Standards.ipynb into Tools - Module Standoff for IEC TS 63126. If so, then we can take the newer 4 - Standards from the development branch and rename it again. I had to make some changes to get the notebook running for Mike on the development branch.

The notebook numbering seems different too. Previously we had 2 for degradation, 3 for spectral degradation, 4 for standards, and 5 for Weather database. In the new version, spectral degradation has 2 for the .py file but 3 for the .ipynb. And weather also has 3. Not sure what it should be.

@shirubana shirubana requested review from MDKempe and removed request for martin-springer May 3, 2024 22:13
Copy link
Collaborator

@MDKempe MDKempe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silvana made me do it.

shirubana added 2 commits May 3, 2024 16:24
asdf
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.24%. Comparing base (7e6c16e) to head (48eedaf).

❗ Current head 48eedaf differs from pull request most recent head 893e80e. Consider uploading reports for the commit 893e80e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           development      #83   +/-   ##
============================================
  Coverage        63.24%   63.24%           
============================================
  Files               29       29           
  Lines             2065     2065           
============================================
  Hits              1306     1306           
  Misses             759      759           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shirubana shirubana merged commit dbde447 into development May 3, 2024
5 checks passed
@shirubana shirubana deleted the Training&Tools branch May 3, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants